From 103e3e7e3fe318a78343050b9144acc9d1e3de75 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Rodr=C3=ADguez?= Date: Mon, 9 Sep 2024 13:02:17 +0200 Subject: [PATCH] Restore support for passing custom command lines as PARALLEL_TESTS_EXECUTABLE. --- CHANGELOG.md | 2 ++ lib/parallel_tests/test/runner.rb | 2 +- spec/parallel_tests/test/runner_spec.rb | 6 ++++++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c5db9bc2..a318854c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,8 @@ ### Fixed +- Restore support for passing custom command lines as PARALLEL_TESTS_EXECUTABLE. + ## 4.7.1 - 2024-04-25 ### Added diff --git a/lib/parallel_tests/test/runner.rb b/lib/parallel_tests/test/runner.rb index d77a40bb..21e2a50d 100644 --- a/lib/parallel_tests/test/runner.rb +++ b/lib/parallel_tests/test/runner.rb @@ -158,7 +158,7 @@ def command_with_seed(cmd, seed) def executable if (executable = ENV['PARALLEL_TESTS_EXECUTABLE']) - [executable] + Shellwords.shellsplit(executable) else determine_executable end diff --git a/spec/parallel_tests/test/runner_spec.rb b/spec/parallel_tests/test/runner_spec.rb index 833ea4cf..624dd6fa 100644 --- a/spec/parallel_tests/test/runner_spec.rb +++ b/spec/parallel_tests/test/runner_spec.rb @@ -18,6 +18,12 @@ def call(*args) expect(a).to include("script/custom_rspec") end call(['xxx'], 1, 22, {}) + + ENV['PARALLEL_TESTS_EXECUTABLE'] = 'ruby -Icustom_option script/custom_rspec' + expect(ParallelTests::Test::Runner).to receive(:execute_command) do |a, _, _, _d| + expect(a).to include("ruby", "-Icustom_option", "script/custom_rspec") + end + call(['xxx'], 1, 22, {}) end it "uses options" do