Skip to content

Conversation

@kingspride
Copy link
Contributor

Discovered that php composer still asks questions interactively when running upgrade.php with --no-interactive.

added an environment variable to set composer to be silent aswell.

snipe added 30 commits May 23, 2025 13:07
Signed-off-by: snipe <[email protected]>

# Conflicts:
#	config/version.php
Signed-off-by: snipe <[email protected]>

# Conflicts:
#	config/version.php
Signed-off-by: snipe <[email protected]>

# Conflicts:
#	config/version.php
snipe and others added 22 commits September 15, 2025 10:32
# Conflicts:
#	config/version.php
# Conflicts:
#	public/css/build/app.css
#	public/css/build/app.css.map
#	public/css/build/overrides.css
#	public/css/build/overrides.css.map
#	public/css/dist/all.css
#	public/mix-manifest.json
Added additional fields to bug report template related to FMCS
@kingspride kingspride requested a review from snipe as a code owner September 26, 2025 09:53
@snipe
Copy link
Member

snipe commented Sep 26, 2025

Hi there - thanks for this! Can you please re-target this PR to point to the develop branch, per our Contributing documentation?

You don't need to close and re-open. After you create a pull request, you can modify the base branch so that the changes in the pull request are compared against a different branch. By changing the base branch of your original pull request rather than opening a new one with the correct base branch, you’ll be able to keep valuable work and discussion.

mhuxq

Thanks!

@kingspride kingspride changed the base branch from master to develop September 26, 2025 10:02
@kingspride
Copy link
Contributor Author

Sorry, clearly an RTFM moment 🤪
I've switched target branches.

thanks for creating this tool :)

@snipe
Copy link
Member

snipe commented Sep 29, 2025

Heh, might need a rebase too - look at the file changes and commit list.

@kingspride
Copy link
Contributor Author

created a new PR #17945

@kingspride kingspride closed this Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants