-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide base stylesheet with responsive defaults #139
Comments
Some initial thoughts to get things rolling:
|
@mrwweb I totally agree with most of that. Regarding (2), I agree that we should have at least a couple different options, a base level that is a no-brainer to include, and something else that includes a basic layout (I imagine the majority of stylesheets would benefit from something like @baldwint's Here's another question I don't know the answer to: if our base stylesheet doesn't provide layout hints (like floating the sidebar), can it still offer sane responsive defaults that will work for everyone? Or are those two things linked too strongly to be separated? |
I think that makes sense for the layout sheet that people can optionally include.
I think that can work. And if that's the case, I think loading it directly in the head and not making it optional might make sense. If those styles are light on CSS specificity, overriding won't be much of a problem. (This is another reason to avoid IDs, then stylesheet authors could use them instead of something like !important or the double-class hack.)
A plain HTML page is responsive, so CSS mostly just breaks responsiveness. The only "sane-default" I can really think of that might be worth including would be a max-width on the body/wrapper, but even that is specific to font-size and layout. The other issue is a mobile menu which I'm going to put in a separate ticket right now. |
Good point, I had contemplated that option earlier and moved away from it, but now you're making me think again that it might be the way to go. We can definitely keep those things low on specificity, and overriding sends the right implicit message of "go ahead, but now this is tightly coupled and you're responsible for keeping up with changes".
Huh, I'd never thought of it that simply, but you're right, I tried disabling CSS and the small screen does pretty okay with that. So I guess we should focus more on a |
We want to provide a base stylesheet that provides reasonable defaults that stylesheet authors may use to get them started. In general, it should aim to be unopinionated, as far as that's possible while still being useful. We already have something along these lines but we need to:
The text was updated successfully, but these errors were encountered: