Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StoryHandle pointer needs to be protected #258

Open
ibrodkin opened this issue Feb 5, 2025 · 0 comments
Open

StoryHandle pointer needs to be protected #258

ibrodkin opened this issue Feb 5, 2025 · 0 comments

Comments

@ibrodkin
Copy link
Collaborator

ibrodkin commented Feb 5, 2025

Make StoryHandle pointer returned to the client in AcquireStory method needs to be protected as a shared pointer or a wrapper on the StoryHandle implementation that is used internally

With the current implementation StoryHandle it's exposed to the client & also used internally. We should not risk the Client deleting the pointer while we still reference it or vice versa

@ibrodkin ibrodkin added this to the 2025-02-28 milestone Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant