Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better test instructions #74

Closed
gonzus opened this issue Oct 12, 2018 · 3 comments
Closed

better test instructions #74

gonzus opened this issue Oct 12, 2018 · 3 comments

Comments

@gonzus
Copy link

gonzus commented Oct 12, 2018

The readme says:
To run tests, please download googletest from https://github.com/google/googletest/archive/release-1.8.0.zip and unzip it in the test subdirectory.

And that's it. I downloaded googletest in the test directory, ran cmake . and then tried with several make targets, but they all failed:

libgraphqlparser/test/ParserTests.cpp:13:10: fatal error: 'Ast.h' file not found

(after adding symlinks for the missing header files)

libgraphqlparser/test/Ast.h:237:43: error: a space is required between consecutive right angle brackets (use '> >')

I am pretty sure I missed a step here. Could some more detailed info be provided in the readme? Perhaps add a test/README.md?

@ErikWittern
Copy link
Contributor

@gonzus Have you been able to figure this out? Running into the same problem.

@gonzus
Copy link
Author

gonzus commented Jul 22, 2019

Nope, sorry @ErikWittern -- and I am on holiday right now, so won't be able to test this for a few weeks.

ErikWittern pushed a commit to ErikWittern/libgraphqlparser that referenced this issue Jul 22, 2019
@ErikWittern
Copy link
Contributor

@gonzus No worries. I got the tests running and filed a PR to fix things and improve the documentation. The latest error you receive has to do with your compiler not targeting C++ 11, it seems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants