-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support triple-quoted block strings #44
Comments
Good catch! The null value is a special case that I missed because it has no fields besides the source location. |
Hello, I am afraid the kitchen test changed a few months ago. Testing on a fresh $ # Init
$ git clone https://github.com/graphql/libgraphqlparser
$ cd libgraphqlparser/
$ cmake .
$ make
$ # Test
$ curl -OL https://raw.githubusercontent.com/graphql/graphql-js/master/src/language/__tests__/kitchen-sink.graphql
$ ./dump_json_ast kitchen-sink.graphql
Parser failed with error: 49.58-59: Unterminated string Am I doing something wrong? Edit: diff between reference graphql-js test and hosted kitchen test: fragment frag on Friend {
- foo(size: $size, bar: $b, obj: {key: "value"})
+ foo(size: $size, bar: $b, obj: {key: "value", block: """
+
+ block string uses \"""
+
+ """})
} |
swolchok
changed the title
Trailing comma's in kitchen sink test:
Support triple-quoted block strings
Jul 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@schloerke has found in our R bindings that the kitchen sink example produces invalid JSON:
The output has an invalid trailing comma (which you can validate on http://pro.jsonlint.com)
The text was updated successfully, but these errors were encountered: