Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArrayValue is used instead of ListValue #27

Closed
joshprice opened this issue Mar 7, 2016 · 5 comments
Closed

ArrayValue is used instead of ListValue #27

joshprice opened this issue Mar 7, 2016 · 5 comments

Comments

@joshprice
Copy link

ArrayValue isn't referenced in the spec but ListValue is https://facebook.github.io/graphql/#sec-List-Value.

With a query like:

{
  field(input: {a: ["bar"])
}

I get something like:

"value": {
  "kind": "ArrayValue",
 ...
}

I'd expect:

"value": {
  "kind": "ListValue",
 ...
}

which would mirror the spec

@joshprice
Copy link
Author

/cc @aarvay

@swolchok
Copy link
Contributor

swolchok commented Mar 7, 2016

Oh, this changed out from under me: graphql/graphql-js@0f784fd

Good catch! Update coming.

@swolchok
Copy link
Contributor

swolchok commented Mar 7, 2016

fixed by 5b83654

@swolchok swolchok closed this as completed Mar 7, 2016
@aarvay
Copy link
Contributor

aarvay commented Mar 7, 2016

Thanks for the fix, @swolchok 👍

@joshprice
Copy link
Author

Thanks @swolchok, appreciate your work on this 🙏

On Tuesday, 8 March 2016, Vignesh Rajagopalan [email protected]
wrote:

Thanks for the fix, @swolchok https://github.com/swolchok [image: 👍]


Reply to this email directly or view it on GitHub
#27 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants