Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2024-03] Ensure use of "composite" term doesn't cause confusion in GraphQL.js #1500

Open
benjie opened this issue Mar 11, 2024 · 5 comments
Assignees
Labels
Action item 🎬 Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings.

Comments

@benjie
Copy link
Member

benjie commented Mar 11, 2024

Check out wording in GraphQL.js to ensure this wording change can’t cause confusion and add non-normative note explaining composite referring to object/interface/union


Note: Action Item issues are reviewed and closed during Working Group
meetings.

@benjie

This comment was marked as resolved.

@JoviDeCroock

This comment was marked as resolved.

@JoviDeCroock
Copy link
Member

I double and triple checked but could not find confusion

@benjie benjie added the Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings. label Jan 15, 2025
@benjie
Copy link
Member Author

benjie commented Jan 15, 2025

The related PR was merged in June:

@JoviDeCroock
Copy link
Member

JoviDeCroock commented Jan 15, 2025

For reference https://github.com/graphql/graphql-js/blob/48afd37a48d37f6d3342b959e8cb34e1ecbfeffb/src/type/definition.ts#L293 - we could go further in this and remove comments as well but I don't particularly mind the overarching term in an implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Action item 🎬 Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings.
Projects
None yet
Development

No branches or pull requests

2 participants