Skip to content

Backport schema coordinates #4493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2025
Merged

Backport schema coordinates #4493

merged 1 commit into from
Oct 31, 2025

Conversation

@JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Oct 14, 2025

Backports #3044

@JoviDeCroock JoviDeCroock requested a review from a team as a code owner October 14, 2025 10:35
@JoviDeCroock JoviDeCroock force-pushed the backport-schema-coordinates branch 4 times, most recently from 14c3189 to ab41972 Compare October 14, 2025 11:14
@martinbonnin
Copy link

martinbonnin commented Oct 29, 2025

Ping @magicmark , @phryneas, @yaacovCR, @Urigo, @benjie, @jerelmiller, can we get some 👀 on this PR ?

magicmark
magicmark approved these changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@magicmark magicmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay! thanks!

jerelmiller
jerelmiller approved these changes Oct 31, 2025
View reviewed changes
Copy link

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@JoviDeCroock JoviDeCroock merged commit e2457b3 into 16.x.x Oct 31, 2025
35 checks passed
benjie
benjie reviewed Oct 31, 2025
View reviewed changes
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JoviDeCroock JoviDeCroock deleted the backport-schema-coordinates branch October 31, 2025 10:10
@JoviDeCroock JoviDeCroock added the PR: feature 🚀 requires increase of "minor" version number label Oct 31, 2025
@fisker fisker mentioned this pull request Nov 4, 2025
Open
3 tasks
@fisker
Copy link

fisker commented Nov 7, 2025

Hello, I'm from the Prettier team.

We want add support for this new ASTs introduced in this PR, but I'm not familiar with graphql, and there seems no test fixtures in this PR to generate these new nodes, I was not able to test.

Can someone help us to solve prettier/prettier#18212 ?
Or provide some tests will help us too.

Thanks!

@JoviDeCroock
Copy link
Member Author

JoviDeCroock commented Nov 8, 2025

@fisker this is a separate parser to parse schema-coordinates which are just strings like shown in the tests. This isn't an expansion of the main syntax like the executable descriptions are, I don't think any action from prettier is needed

@benjie
Copy link
Member

benjie commented Nov 8, 2025

And to be clearer: schema coordinates only have one representation, there is no formatting (no spaces, commas, newlines), so definitely out of scope for prettier.

@fisker
Copy link

fisker commented Nov 8, 2025

@JoviDeCroock @benjie Thank you for the information!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjie benjie benjie left review comments

@martinbonnin martinbonnin martinbonnin approved these changes

+2 more reviewers

@jerelmiller jerelmiller jerelmiller approved these changes

@magicmark magicmark magicmark approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: feature 🚀 requires increase of "minor" version number

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@JoviDeCroock @martinbonnin @fisker @benjie @jerelmiller @magicmark