fix(ruby): remove thread_id crate

Author: korniltsev

Cargo.lock

@@ -24,7 +24,6 @@ members = [
     "pyroscope_backends/pyroscope_pyspy",
     "pyroscope_cli",
     "pyroscope_ffi/ruby/ext/rbspy",
-    "pyroscope_ffi/ruby/ext/thread_id",
     "pyroscope_ffi/python/lib",
     "pyroscope_ffi/ffikit",
 ]

Cargo.toml

@@ -22,7 +22,6 @@ ADD pyroscope_cli pyroscope_cli
 ADD pyroscope_ffi/ pyroscope_ffi/
 # TODO --frozen
 RUN --mount=type=cache,target=/root/.cargo/registry cargo build -p ffiruby --release
-RUN --mount=type=cache,target=/root/.cargo/registry cargo build -p thread_id --release
 
 FROM ruby:3.3 as builder-gem
 WORKDIR /gem
@@ -31,7 +30,6 @@ ADD pyroscope_ffi/ruby /gem/
 RUN bundle install
 
 COPY --from=builder /pyroscope-rs/target/release/librbspy.so lib/rbspy/rbspy.so
-COPY --from=builder /pyroscope-rs/target/release/libthread_id.so lib/thread_id/thread_id.so
 ARG TARGET_TASK
 RUN rake ${TARGET_TASK}
 

docker/gem.Dockerfile

@@ -2,11 +2,8 @@
 .phony: dev
 dev:
 	cd ext/rbspy &&  cargo build --frozen --offline
-	cd ext/thread_id && cargo build --frozen --offline
 	mkdir -p lib/rbspy/
 	cp ../../target/debug/librbspy.so lib/rbspy/rbspy.so
-	mkdir -p lib/thread_id/
-	cp ../../target/debug/libthread_id.so lib/thread_id/thread_id.so
 	bundle install
 	rake x86_64_linux:gem # todo wth is it so slow
 	for i in $$(ls -tr pkg/pyroscope-*-x86_64-linux.gem | tail -n 1); do gem install ./$$i; done;

pyroscope_ffi/ruby/Makefile

@@ -13,7 +13,6 @@ rescue Bundler::BundlerError => e
 	exit e.status_code
 end
 
-load File.expand_path('./ext/thread_id/Rakefile', __dir__)
 load File.expand_path('./ext/rbspy/Rakefile', __dir__)
 
 task default: %w[hello]
@@ -33,7 +32,6 @@ namespace :x86_64_darwin do
   spec = Bundler.load_gemspec('pyroscope.gemspec')
   spec.platform = 'x86_64-darwin'
   spec.files += FileList['lib/rbspy/rbspy.*']
-  spec.files += FileList['lib/thread_id/thread_id.*']
   spec.extensions = []
 
   Gem::PackageTask.new(spec) do |pkg|
@@ -44,7 +42,6 @@ namespace :arm64_darwin do
   spec = Bundler.load_gemspec('pyroscope.gemspec')
   spec.platform = 'arm64-darwin'
   spec.files += FileList['lib/rbspy/rbspy.*']
-  spec.files += FileList['lib/thread_id/thread_id.*']
   spec.extensions = []
 
   Gem::PackageTask.new(spec) do |pkg|
@@ -56,7 +53,6 @@ namespace :x86_64_linux do
   spec.platform = 'x86_64-linux'
   spec.files += FileList['lib/rbspy/rbspy.*']
   spec.files += FileList['lib/rbspy.libs/*']
-  spec.files += FileList['lib/thread_id/thread_id.*']
   spec.extensions = []
 
   Gem::PackageTask.new(spec) do |pkg|
@@ -68,7 +64,6 @@ namespace :aarch64_linux do
   spec.platform = 'aarch64-linux'
   spec.files += FileList['lib/rbspy/rbspy.*']
   spec.files += FileList['lib/rbspy.libs/*']
-  spec.files += FileList['lib/thread_id/thread_id.*']
   spec.extensions = []
 
   Gem::PackageTask.new(spec) do |pkg|

pyroscope_ffi/ruby/Rakefile

@@ -15,6 +15,7 @@ ffikit = { path = "../../../ffikit" }
 # todo remove this dependency
 pretty_env_logger = "0.5"
 log = "0.4"
+libc = "0.2.171"
 
 [build-dependencies]
 cbindgen = "0.28"

pyroscope_ffi/ruby/ext/rbspy/Cargo.toml

@@ -32,9 +32,9 @@ bool initialize_agent(const char *application_name,
 
 bool drop_agent(void);
 
-bool add_thread_tag(uint64_t thread_id, const char *key, const char *value);
+bool add_thread_tag(const char *key, const char *value);
 
-bool remove_thread_tag(uint64_t thread_id, const char *key, const char *value);
+bool remove_thread_tag(const char *key, const char *value);
 
 bool add_global_tag(const char *key, const char *value);