From 2cb15fb09f1820ff7ed0fa8f26f12c78a3c70c8a Mon Sep 17 00:00:00 2001
From: tanner <tanner@dunamu.com>
Date: Wed, 5 Nov 2025 20:48:55 +0900
Subject: [PATCH] [rollout-operator] Unset default
 webhooks.selfSignedCertSecretName and use chart's fullname

Signed-off-by: tanner <tanner@dunamu.com>
---
 charts/rollout-operator/Chart.yaml                  | 2 +-
 charts/rollout-operator/README.md                   | 4 ++--
 charts/rollout-operator/templates/deployment.yaml   | 2 +-
 charts/rollout-operator/templates/webhook-role.yaml | 2 +-
 charts/rollout-operator/values.yaml                 | 2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/charts/rollout-operator/Chart.yaml b/charts/rollout-operator/Chart.yaml
index 0e72094cc6..9f9109fc5c 100644
--- a/charts/rollout-operator/Chart.yaml
+++ b/charts/rollout-operator/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: rollout-operator
 description: "Grafana rollout-operator"
 type: application
-version: 0.37.1
+version: 0.38.0
 appVersion: v0.32.0
 home: https://github.com/grafana/rollout-operator
 kubeVersion: ^1.10.0-0
diff --git a/charts/rollout-operator/README.md b/charts/rollout-operator/README.md
index c8535097f4..35b78af36b 100644
--- a/charts/rollout-operator/README.md
+++ b/charts/rollout-operator/README.md
@@ -4,7 +4,7 @@ Helm chart for deploying [Grafana rollout-operator](https://github.com/grafana/r
 
 # rollout-operator
 
-![Version: 0.37.1](https://img.shields.io/badge/Version-0.37.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v0.32.0](https://img.shields.io/badge/AppVersion-v0.32.0-informational?style=flat-square)
+![Version: 0.38.0](https://img.shields.io/badge/Version-0.38.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v0.32.0](https://img.shields.io/badge/AppVersion-v0.32.0-informational?style=flat-square)
 
 Grafana rollout-operator
 
@@ -85,4 +85,4 @@ Manually applying these CRDs is only required if upgrading from a chart <= v0.32
 | tolerations | list | `[]` |  |
 | webhooks.enabled | bool | `true` | Enable the rollout-operator webhooks. See https://github.com/grafana/rollout-operator/#webhooks. Note that the webhooks require custom resource definitions. If upgrading, manually apply the files in the `crds` directory. |
 | webhooks.failurePolicy | string | `"Fail"` | Validating and mutating webhook failure policy. `Ignore` or `Fail`. |
-| webhooks.selfSignedCertSecretName | string | `"certificate"` | Secret resource name for the TLS certificate to be used with the webhooks |
+| webhooks.selfSignedCertSecretName | string | `""` | Secret resource name for the TLS certificate to be used with the webhooks |
diff --git a/charts/rollout-operator/templates/deployment.yaml b/charts/rollout-operator/templates/deployment.yaml
index dd79cd186d..303095bdaf 100644
--- a/charts/rollout-operator/templates/deployment.yaml
+++ b/charts/rollout-operator/templates/deployment.yaml
@@ -53,7 +53,7 @@ spec:
           - -kubernetes.namespace={{ .Release.Namespace }}
           {{- if .Values.webhooks.enabled }}
           - -server-tls.enabled=true
-          - -server-tls.self-signed-cert.secret-name={{ .Values.webhooks.selfSignedCertSecretName }}
+          - -server-tls.self-signed-cert.secret-name={{ .Values.webhooks.selfSignedCertSecretName | default (include "rollout-operator.fullname" . )  }}
           - -server-tls.self-signed-cert.dns-name={{ include "rollout-operator.fullname" . }}.{{ .Release.Namespace }}.svc
           {{- end }}
           {{- range .Values.extraArgs  }}
diff --git a/charts/rollout-operator/templates/webhook-role.yaml b/charts/rollout-operator/templates/webhook-role.yaml
index 8d548632ef..2cc45b1869 100644
--- a/charts/rollout-operator/templates/webhook-role.yaml
+++ b/charts/rollout-operator/templates/webhook-role.yaml
@@ -13,7 +13,7 @@ rules:
       - update
       - get
     resourceNames:
-      - {{ .Values.webhooks.selfSignedCertSecretName }}
+      - {{ .Values.webhooks.selfSignedCertSecretName | default (include "rollout-operator.fullname" . )  }}
   - apiGroups:
       - ""
     resources:
diff --git a/charts/rollout-operator/values.yaml b/charts/rollout-operator/values.yaml
index e589bd1d02..dd95e01af1 100644
--- a/charts/rollout-operator/values.yaml
+++ b/charts/rollout-operator/values.yaml
@@ -107,4 +107,4 @@ webhooks:
   # -- Validating and mutating webhook failure policy. `Ignore` or `Fail`.
   failurePolicy: "Fail"
   # -- Secret resource name for the TLS certificate to be used with the webhooks
-  selfSignedCertSecretName: "certificate"
+  selfSignedCertSecretName: ""