Skip to content

grafana agent flow vs windows_exporter process collector #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DavidSkDerivco opened this issue Feb 22, 2024 · 10 comments
Open

grafana agent flow vs windows_exporter process collector #239

DavidSkDerivco opened this issue Feb 22, 2024 · 10 comments
Labels
bug Something isn't working

Comments

@DavidSkDerivco
Copy link

What's wrong?

w3wp processes do not have iis process names when collecting when running Grafana Agent Flow v0.39.1
Example when running windows_exporter v0.24.0 - windows_process_cpu_time_total{creating_process_id="1234",mode="user",process="w3wp_DefaultAppPool",process_id="123456"}
Example running Grafana Agent Flow v0.39.1 - windows_process_cpu_time_total{creating_process_id="1234",mode="user",process="w3wp",process_id="12345"} 111.8125

Steps to reproduce

Install Grafana Agent Flow v0.39.1 and compare with install of windows_exporter v0.24.0
Check "windows_process" metrics

System information

Windows Server 2019

Software version

Grafana Agent Flow v0.39.1

Configuration

prometheus.exporter.windows "os_metrics" {
  enabled_collectors = ["process","iis"]
  process {
    include = "Idle|w3w.*|grafana.+"
  }
}

Logs

No logs on this event
@DavidSkDerivco DavidSkDerivco added the bug Something isn't working label Feb 22, 2024
@jaco-van-zyl-derivco
Copy link

jaco-van-zyl-derivco commented Feb 22, 2024

It does not look like the flag is available in the grafana agent config

--collector.process.iis
Enables IIS process name queries. IIS process names are combined with their app pool name to form the process label.
Disabled by default, and can be enabled with --collector.process.iis=true.

@tpaschalis
Copy link
Member

Looks like @jaco-van-zyl-derivco is right, we haven't wired this new config field and only have include/exclude. Would any of you be interested in wiring this in?

@jaco-van-zyl-derivco
Copy link

I am happy to attempt this addition

Copy link
Contributor

This issue has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If the opened issue is a bug, check to see if a newer release fixed your issue. If it is no longer relevant, please feel free to close this issue.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your issue will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@jaco-van-zyl-derivco
Copy link

Awaiting a new build of the windows_exporter

@rfratto
Copy link
Member

rfratto commented Apr 11, 2024

Hi there 👋

On April 9, 2024, Grafana Labs announced Grafana Alloy, the spirital successor to Grafana Agent and the final form of Grafana Agent flow mode. As a result, Grafana Agent has been deprecated and will only be receiving bug and security fixes until its end-of-life around November 1, 2025.

To make things easier for maintainers, we're in the process of migrating all issues tagged variant/flow to the Grafana Alloy repository to have a single home for tracking issues. This issue is likely something we'll want to address in both Grafana Alloy and Grafana Agent, so just because it's being moved doesn't mean we won't address the issue in Grafana Agent :)

@rfratto rfratto transferred this issue from grafana/agent Apr 11, 2024
@fr34kyn01535
Copy link

This is still not configurable in Grafana Alloy.

@jaco-vanzyl
Copy link

This is being done here

@fr34kyn01535
Copy link

@jaco-vanzyl are the service configs also covered? where_clause etc?

@jaco-vanzyl
Copy link

@jaco-vanzyl are the service configs also covered? where_clause etc?

That exists already -> https://grafana.com/docs/alloy/latest/reference/components/prometheus/prometheus.exporter.windows/#service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants