Skip to content

Commit 93ede44

Browse files
committed
Add 'connector' to help, interactive, and error text
1 parent a8b7e1e commit 93ede44

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

components/scripts/gradle/05-validate-remote-build-caching-ci-local.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -391,11 +391,11 @@ collect_remote_build_cache() {
391391

392392
collect_remote_build_cache_type() {
393393
local default_remote_cache_type="<project default>"
394-
prompt_for_setting "What is the remote build cache type to use? [develocity, gradle-enterprise, http, or <BLANK>]" "${remote_build_cache_type}" "${default_remote_cache_type}" remote_build_cache_type
394+
prompt_for_setting "What is the remote build cache connector type to use? [develocity, gradle-enterprise, http, or <BLANK>]" "${remote_build_cache_type}" "${default_remote_cache_type}" remote_build_cache_type
395395

396396
if [[ -n "${remote_build_cache_type}" && "${remote_build_cache_type}" != 'http' && "${remote_build_cache_type}" != 'gradle-enterprise' && "${remote_build_cache_type}" != 'develocity' ]]; then
397397
print_bl
398-
die "ERROR: Invalid value for remote build cache type. Values are 'develocity', 'gradle-enterprise', 'http', or <BLANK> for project default." "${INVALID_INPUT}"
398+
die "ERROR: Invalid value for remote build cache connector type. Values are 'develocity', 'gradle-enterprise', 'http', or <BLANK> for project default." "${INVALID_INPUT}"
399399
fi
400400

401401
if [[ "${remote_build_cache_type}" == "${default_remote_cache_type}" ]]; then

components/scripts/gradle/gradle-init-scripts/configure-remote-build-caching.gradle

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ static String toServerPart(URI uri) {
9595
// This is for the sake of completeness since this init script assumes it's valid.
9696
static void failInvalidRemoteBuildCacheType(String remoteBuildCacheType, String expDir) {
9797
def errorFile = new File(expDir, 'errors.txt')
98-
def message = "Invalid value '${remoteBuildCacheType}' for remote build cache type. Values are 'develocity', 'gradle-enterprise', or 'http'."
98+
def message = "Invalid value '${remoteBuildCacheType}' for remote build cache connector type. Values are 'develocity', 'gradle-enterprise', or 'http'."
9999
errorFile.text = message
100100
throw new IllegalStateException(message)
101101
}
@@ -104,16 +104,16 @@ static void failInvalidRemoteBuildCacheType(String remoteBuildCacheType, String
104104
// Only fail if the top-level build is missing the required extension.
105105
static void failMissingRequiredPlugin(String remoteBuildCacheType, String expDir, String docsRoot) {
106106
def errorFile = new File(expDir, 'errors.txt')
107-
errorFile.text = "Remote build cache type '${remoteBuildCacheType}' requested, but the required plugin is not applied."
107+
errorFile.text = "Remote build cache connector type '${remoteBuildCacheType}' requested, but the required plugin is not applied."
108108
if (remoteBuildCacheType == 'develocity') {
109-
throw new IllegalStateException("Remote build cache type 'develocity' requested,\n" +
109+
throw new IllegalStateException("Remote build cache connector type 'develocity' requested,\n" +
110110
"but the Develocity Gradle plugin is not applied.\n" +
111111
"Either apply it directly (see $docsRoot/current/#applying_the_plugin),\n" +
112112
"use --enable-develocity to enable the plugin,\n" +
113-
"or use --remote-build-cache-type to choose a different remote build cache type\n" +
113+
"or use --remote-build-cache-type to choose a different remote build cache connector type\n" +
114114
"when running the build validation script.")
115115
} else {
116-
throw new IllegalStateException("Remote build cache type 'gradle-enterprise' requested,\n" +
116+
throw new IllegalStateException("Remote build cache connector type 'gradle-enterprise' requested,\n" +
117117
"but the Gradle Enterprise Gradle plugin is not applied (see $docsRoot/legacy/#applying_the_plugin).")
118118
}
119119
}

components/scripts/lib/cli-parsers/gradle/05-cli-parser.m4

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ function print_help() {
3131
print_option_usage -p
3232
print_option_usage -t
3333
print_option_usage -a
34-
print_option_usage "-y, --remote-build-cache-type" "Specifies the type of remote build cache to use in the second build run locally. Values are 'develocity', 'gradle-enterprise', or 'http'."
34+
print_option_usage "-y, --remote-build-cache-type" "Specifies the remote build cache connector type to use in the second build run locally. Values are 'develocity', 'gradle-enterprise', or 'http'."
3535
print_option_usage "-u, --remote-build-cache-url" "Specifies the URL for the remote build cache to access in the second build run locally."
3636
print_option_usage -s
3737
print_option_usage -e

0 commit comments

Comments
 (0)