From 82f17d1672c780f4ba9c5172b75ab59bb4b28229 Mon Sep 17 00:00:00 2001 From: Stefan Marr Date: Tue, 30 Jan 2024 13:44:18 +0000 Subject: [PATCH] Make note about MX_BUILD_EXPLODED conditional on it not being true This is really a very minor things, though, every time I do a `mx eclipseinit` and it reminds me of MX_BUILD_EXPLODED, I spend a few minutes figuring out whether I got the config wrong. By adding the check, the note is only printed when the configuration is something other than `MX_BUILD_EXPLODED=true`. Signed-off-by: Stefan Marr --- src/mx/_impl/mx_ide_eclipse.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mx/_impl/mx_ide_eclipse.py b/src/mx/_impl/mx_ide_eclipse.py index e1d1fbbe..55243475 100644 --- a/src/mx/_impl/mx_ide_eclipse.py +++ b/src/mx/_impl/mx_ide_eclipse.py @@ -484,8 +484,9 @@ def eclipseinit_cli(args): mx.log(' Projects needed for development can be opened conveniently using the generated Suite working sets from the context menu.') mx.log(' 5) Update the type filters (Preferences -> Java -> Appearance -> Type Filters) so that `jdk.*` and `org.graalvm.*` are not filtered.') mx.log(' Without this, code completion will not work for JVMCI and Graal code.') - mx.log('') - mx.log('Note that setting MX_BUILD_EXPLODED=true can improve Eclipse build times. See "Exploded builds" in the mx README.md.') + if mx.get_env('MX_BUILD_EXPLODED', None) != 'true': + mx.log('') + mx.log('Note that setting MX_BUILD_EXPLODED=true can improve Eclipse build times. See "Exploded builds" in the mx README.md.') mx.log('----------------------------------------------') if _EclipseJRESystemLibraries: