Skip to content

Commit 8a39e1d

Browse files
authored
Only try OOM allocation size with 'absurd' value (#4489)
The current value version of the OOM allocation causes issues with machines that have more than 128GB of RAM. Since one of the values it tries to test is 128GB. This change removes this lower value, leaving the higher value kMaxSafeMultipleOf8, which is ~8,192TB. I am aware of no commercially available machine supports anything near this much RAM, so this should be good for the foreseeable future. If there is a device in the future with this much RAM, hopefully Number will have been re-specified to something like a float128 by then. Fixes #4488
1 parent 6dffd78 commit 8a39e1d

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

src/webgpu/api/operation/buffers/map_oom.spec.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,7 @@ import { kMaxSafeMultipleOf8 } from '../../../util/math.js';
1010
const oomAndSizeParams = kUnitCaseParamsBuilder
1111
.combine('oom', [false, true])
1212
.expand('size', ({ oom }) => {
13-
return oom
14-
? [
15-
kMaxSafeMultipleOf8,
16-
0x20_0000_0000, // 128 GB
17-
]
18-
: [16];
13+
return oom ? [kMaxSafeMultipleOf8] : [16];
1914
});
2015

2116
export const g = makeTestGroup(AllFeaturesMaxLimitsGPUTest);

0 commit comments

Comments
 (0)