Make transaction details optional #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janopae
force-pushed
the
make_transaction_details_optional
branch
from
cb912db to
00d0f5f
Compare
|
#3 also protects against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few weeks ago, I had problems using this because the key
transaction_detailswas missing. I dirtily hacked a solution by hacking the python scripts in my installation, but I planned to properly commit it back upstream. For doing so, I wrote some unit tests.I now realised that in the meantime, an issue and a PR have already been created for this (#3). However, I decided to PR this anyway, because I also made unit tests for my fix.
Also, my fix uses the field "purpose" for the memo in case "transaction_details" are missing (which is what my bank provides, and it seems to contain what you'd expect a memo to contain).
Please merge only after #4 has been merged.
Fixes #2.