More explicit logger configuration

[areknoster]

Currently the logger is pretty hard to discover in https://github.com/gost-dom/browser/blob/main/logger/logger.go
In many cases it's the only tool that we have to discover what went wrong.
I was wondering if it wouldn't make sense to inject the logger to browser instance (or window instance, whatever feels more natural).

I Imagine it as something like

// default, silent
b := browser.New(browser.Config{}) 
//  initialize with logger so I can learn what's wrong
b = browser.New(browser.Config{
   Logger: slog.Default(), 
}

Or, if you prefer functional opts

// default, silent
b := browser.New() 
// initialize with logger so I can learn what's wrong
b = browser.New(browser.WithLogger(slog.Default())

[stroiman]

It's true, I haven't made too much fuzz about the logger, and that's partly because I felt that it wasn't really "ready". One question I did intend to ask into the community was best practices regarding logging from libraries.

I have had the same idea as you, passing it to a browser, and from a user's perspective, that certainly makes a lot of sense - giving each test case control of the level of output. It does seem to have the consequence that most objects need to have some extra logger field though, or embed - so the right logger can be used.

Or maybe it makes sense to have a context.Context being passed around, and the logger exists as a field on the context?

Also I wanted to have some kind of options on filtering on the types of messages. At the moment it's just based on log level. I'm not sure what would be the best approach here, so also something I would like input for.

[areknoster]

I don't think there is much of a need to be very granular on the logs levels. They are used for debugging, so having slightly more or slightly less verbose messagigng shouldn't hurt.

I think explicit logger passing is the best one.
As for internal passing of the logger, I don't have strong opinion on that. I've seen both and both are fine. If we talk about 'idiomatic' go, people would probably point towards explicit DI, but I'm not that dogmatic myself