Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] Horcrux Support #15

Open
jackzampolin opened this issue Aug 19, 2024 · 3 comments
Open

[EPIC] Horcrux Support #15

jackzampolin opened this issue Aug 19, 2024 · 3 comments
Assignees

Comments

@jackzampolin
Copy link
Contributor

jackzampolin commented Aug 19, 2024

Horcrux should support Gordian!

THEY ARE THE SAME! This should be very straightforward

I'm pretty sure @agouin already knows whats involved here but also tagging @Reecepbcups and @mark-rushakoff as this implementation bears on the tooling for grpc services. Also Andy for visibiliy.

@jackzampolin
Copy link
Contributor Author

Note: horcrux uses buf and might be a good opportunity

@Reecepbcups
Copy link
Contributor

Reecepbcups commented Aug 19, 2024

ref buf attempt here: https://github.com/rollchains/gordian/tree/reece/grpc-buf-attempt

cosmos gogoproto is not happy with duplicate registrations. When you hack around that, it does not seem to expose the service? despite it being registered and working perfectly with protoc. Maybe a me thing but feels weird

Got it to be happy, but breaks gRPCurl. So technically work can get started on this once we get the base gRPC in and add on top

@mark-rushakoff
Copy link
Member

Since we've been discussing it in the background for a while, https://github.com/rollchains/gordian/blob/830ecf50f017e9e6b38788a1b959db80ae870b4e/tm/tmconsensus/signer.go is the new, more tm-aware signer interface -- I believe this API has more context necessary for Horcrux to ensure that members are not double-signing for the same height and round, or something like that. @agouin should know better than I do about this part.

@jonathanpberger jonathanpberger changed the title [Epic] Horcrux Support [EPIC] Horcrux Support Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants