Skip to content

Commit 45699bb

Browse files
vinay-googlevinay-google
authored
fix: attribute errors (#429)
1 parent bd32d47 commit 45699bb

File tree

6 files changed

+33
-46
lines changed

6 files changed

+33
-46
lines changed

‎drive/snippets/drive-v2/file snippet/create_folder.py

+3-4
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,12 @@ def create_folder():
4343
# pylint: disable=maybe-no-member
4444
file = service.files().insert(body=file_metadata,
4545
fields='id').execute()
46-
print(F'Folder has created with ID: "{file.get("id")}".')
46+
print(F'Folder ID: "{file.get("id")}".')
47+
return file.get('id')
4748

4849
except HttpError as error:
4950
print(F'An error occurred: {error}')
50-
file = None
51-
52-
return file.get('id')
51+
return None
5352

5453

5554
if __name__ == '__main__':

‎drive/snippets/drive-v2/file snippet/move_file_to_folder.py

+9-11
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,13 @@
2222
from googleapiclient.errors import HttpError
2323

2424

25-
def move_file_to_folder(real_file_id, real_folder_id):
25+
def move_file_to_folder(file_id, folder_id):
2626
"""Move specified file to the specified folder.
2727
Args:
28-
real_file_id: Id of the file to move.
29-
real_folder_id: Id of the folder
28+
file_id: Id of the file to move.
29+
folder_id: Id of the folder
3030
Print: An object containing the new parent folder and other meta data
31+
Returns : Parent Ids for the file
3132
3233
Load pre-authorized user credentials from the environment.
3334
TODO(developer) - See https://developers.google.com/identity
@@ -39,9 +40,6 @@ def move_file_to_folder(real_file_id, real_folder_id):
3940
# call drive api client
4041
service = build('drive', 'v2', credentials=creds)
4142

42-
file_id = real_file_id
43-
folder_id = real_folder_id
44-
4543
# Retrieve the existing parents to remove
4644
# pylint: disable=maybe-no-member
4745
file = service.files().get(fileId=file_id, fields='parents').execute()
@@ -52,16 +50,16 @@ def move_file_to_folder(real_file_id, real_folder_id):
5250
removeParents=previous_parents,
5351
fields='id, parents').execute()
5452
new_parent_folder_id = [parent["id"] for parent in file.get('parents')]
55-
print(F'file with ID : {file.get("id")} has moved to folder : '
53+
print(F'file with ID : {file.get("id")} moved to folder : '
5654
F'{new_parent_folder_id}')
55+
return [parent["id"] for parent in file.get('parents')]
5756

5857
except HttpError as error:
5958
print(F'An error occurred: {error}')
60-
61-
return [parent["id"] for parent in file.get('parents')]
59+
return None
6260

6361

6462
if __name__ == '__main__':
65-
move_file_to_folder(real_file_id='14fesChjgzDA7lUu9ZeGqXOuXMPgaVkxS',
66-
real_folder_id='1KzT9gjq-AHfciwNzKjh7nUd6prrQOA4')
63+
move_file_to_folder(file_id='14fesChjgzDA7lUu9ZeGqXOuXMPgaVkxS',
64+
folder_id='1KzT9gjq-AHfciwNzKjh7nUd6prrQOA4')
6765
# [END drive_move_file_to_folder]

‎drive/snippets/drive-v2/file snippet/upload_to_folder.py

+5-8
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
from googleapiclient.http import MediaFileUpload
2424

2525

26-
def upload_to_folder(real_folder_id):
26+
def upload_to_folder(folder_id):
2727
"""Upload a file to the specified folder and prints file ID, folder ID
2828
Args: Id of the folder
2929
Returns: ID of the file uploaded
@@ -38,7 +38,6 @@ def upload_to_folder(real_folder_id):
3838
# create drive api client
3939
service = build('drive', 'v2', credentials=creds)
4040

41-
folder_id = real_folder_id
4241
file_metadata = {
4342
'title': 'photo.jpg',
4443
'parents': [{'id': folder_id}]
@@ -48,16 +47,14 @@ def upload_to_folder(real_folder_id):
4847
# pylint: disable=maybe-no-member
4948
file = service.files().insert(body=file_metadata,
5049
media_body=media, fields='id').execute()
51-
print(F'File with ID: "{file.get("id")}" has added to the folder with '
52-
F'ID "{real_folder_id}".')
50+
print(F'File ID: "{file.get("id")}".')
51+
return file.get('id')
5352

5453
except HttpError as error:
5554
print(F'An error occurred: {error}')
56-
file = None
57-
58-
return file.get('id')
55+
return None
5956

6057

6158
if __name__ == '__main__':
62-
upload_to_folder(real_folder_id='1s0oKEZZXjImNngxHGnY0xed6Mw-tvspu')
59+
upload_to_folder(folder_id='1s0oKEZZXjImNngxHGnY0xed6Mw-tvspu')
6360
# [END drive_upload_to_folder]

‎drive/snippets/drive-v3/file_snippet/create_folder.py

+3-4
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,12 @@ def create_folder():
4343
# pylint: disable=maybe-no-member
4444
file = service.files().create(body=file_metadata, fields='id'
4545
).execute()
46-
print(F'Folder has created with ID: "{file.get("id")}".')
46+
print(F'Folder ID: "{file.get("id")}".')
47+
return file.get('id')
4748

4849
except HttpError as error:
4950
print(F'An error occurred: {error}')
50-
file = None
51-
52-
return file.get('id')
51+
return None
5352

5453

5554
if __name__ == '__main__':

‎drive/snippets/drive-v3/file_snippet/move_file_to_folder.py

+8-11
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,13 @@
2222
from googleapiclient.errors import HttpError
2323

2424

25-
def move_file_to_folder(real_file_id, real_folder_id):
25+
def move_file_to_folder(file_id, folder_id):
2626
"""Move specified file to the specified folder.
2727
Args:
28-
real_file_id: Id of the file to move.
29-
real_folder_id: Id of the folder
28+
file_id: Id of the file to move.
29+
folder_id: Id of the folder
3030
Print: An object containing the new parent folder and other meta data
31+
Returns : Parent Ids for the file
3132
3233
Load pre-authorized user credentials from the environment.
3334
TODO(developer) - See https://developers.google.com/identity
@@ -39,9 +40,6 @@ def move_file_to_folder(real_file_id, real_folder_id):
3940
# call drive api client
4041
service = build('drive', 'v3', credentials=creds)
4142

42-
file_id = real_file_id
43-
folder_id = real_folder_id
44-
4543
# pylint: disable=maybe-no-member
4644
# Retrieve the existing parents to remove
4745
file = service.files().get(fileId=file_id, fields='parents').execute()
@@ -50,15 +48,14 @@ def move_file_to_folder(real_file_id, real_folder_id):
5048
file = service.files().update(fileId=file_id, addParents=folder_id,
5149
removeParents=previous_parents,
5250
fields='id, parents').execute()
51+
return file.get('parents')
5352

5453
except HttpError as error:
5554
print(F'An error occurred: {error}')
56-
file = None
57-
58-
return file.get('parents')
55+
return None
5956

6057

6158
if __name__ == '__main__':
62-
move_file_to_folder(real_file_id='1KuPmvGq8yoYgbfW74OENMCB5H0n_2Jm9',
63-
real_folder_id='1jvTFoyBhUspwDncOTB25kb9k0Fl0EqeN')
59+
move_file_to_folder(file_id='1KuPmvGq8yoYgbfW74OENMCB5H0n_2Jm9',
60+
folder_id='1jvTFoyBhUspwDncOTB25kb9k0Fl0EqeN')
6461
# [END drive_move_file_to_folder]

‎drive/snippets/drive-v3/file_snippet/upload_to_folder.py

+5-8
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
from googleapiclient.http import MediaFileUpload
2424

2525

26-
def upload_to_folder(real_folder_id):
26+
def upload_to_folder(folder_id):
2727
"""Upload a file to the specified folder and prints file ID, folder ID
2828
Args: Id of the folder
2929
Returns: ID of the file uploaded
@@ -38,7 +38,6 @@ def upload_to_folder(real_folder_id):
3838
# create drive api client
3939
service = build('drive', 'v3', credentials=creds)
4040

41-
folder_id = real_folder_id
4241
file_metadata = {
4342
'name': 'photo.jpg',
4443
'parents': [folder_id]
@@ -48,16 +47,14 @@ def upload_to_folder(real_folder_id):
4847
# pylint: disable=maybe-no-member
4948
file = service.files().create(body=file_metadata, media_body=media,
5049
fields='id').execute()
51-
print(F'File with ID: "{file.get("id")}" has added to the folder with '
52-
F'ID "{real_folder_id}".')
50+
print(F'File ID: "{file.get("id")}".')
51+
return file.get('id')
5352

5453
except HttpError as error:
5554
print(F'An error occurred: {error}')
56-
file = None
57-
58-
return file.get('id')
55+
return None
5956

6057

6158
if __name__ == '__main__':
62-
upload_to_folder(real_folder_id='1s0oKEZZXjImNngxHGnY0xed6Mw-tvspu')
59+
upload_to_folder(folder_id='1s0oKEZZXjImNngxHGnY0xed6Mw-tvspu')
6360
# [END drive_upload_to_folder]

0 commit comments

Comments
 (0)