Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build googleapis in the latest version #35

Open
Nitya05 opened this issue Jul 18, 2018 · 3 comments
Open

Unable to build googleapis in the latest version #35

Nitya05 opened this issue Jul 18, 2018 · 3 comments

Comments

@Nitya05
Copy link

Nitya05 commented Jul 18, 2018

"make LANGUAGE=cpp" for googleapis is giving the following error:

google/ads/googleads/v0/common/custom_parameter.proto:31:8: Option "php_metadata_namespace" unknown.
Makefile:46: recipe for target 'google/ads/googleads/v0/common/custom_parameter.pb.cc' failed
make: *** [google/ads/googleads/v0/common/custom_parameter.pb.cc] Error 1

Any leads on resolving this?

@Fleker
Copy link
Collaborator

Fleker commented Jul 18, 2018

Yeah I'm seeing the same thing. It looks like some changes were made to the googleads protos. I'll see if I can clean up the build process. In the meantime, you should be fine to delete the google/ads/ directory.

protoc --proto_path=.:/usr/local/include --cpp_out=./gens --grpc_out=./gens --plugin=protoc-gen-grpc=/usr/local/bin/grpc_cpp_plugin google/ads/googleads/v0/services/ad_group_service.proto
google/ads/googleads/v0/common/custom_parameter.proto:31:8: Option "php_metadata_namespace" unknown.
google/ads/googleads/v0/enums/ad_group_status.proto:29:8: Option "php_metadata_namespace" unknown.
google/ads/googleads/v0/enums/ad_group_type.proto:29:8: Option "php_metadata_namespace" unknown.
google/ads/googleads/v0/resources/ad_group.proto: Import "google/ads/googleads/v0/common/custom_parameter.proto" was not found or had errors.
google/ads/googleads/v0/resources/ad_group.proto: Import "google/ads/googleads/v0/enums/ad_group_status.proto" was not found or had errors.
google/ads/googleads/v0/resources/ad_group.proto: Import "google/ads/googleads/v0/enums/ad_group_type.proto" was not found or had errors.
google/ads/googleads/v0/resources/ad_group.proto:60:3: "enums.AdGroupStatusEnum.AdGroupStatus" is not defined.
google/ads/googleads/v0/resources/ad_group.proto:63:3: "enums.AdGroupTypeEnum.AdGroupType" is not defined.
google/ads/googleads/v0/resources/ad_group.proto:70:12: "common.CustomParameter" is not defined.
google/ads/googleads/v0/services/ad_group_service.proto: Import "google/ads/googleads/v0/resources/ad_group.proto" was not found or had errors.
google/ads/googleads/v0/services/ad_group_service.proto:76:5: "resources.AdGroup" is not defined.
google/ads/googleads/v0/services/ad_group_service.proto:79:5: "resources.AdGroup" is not defined.
google/ads/googleads/v0/services/ad_group_service.proto:38:46: "resources.AdGroup" is not defined.
make: *** [google/ads/googleads/v0/services/ad_group_service.pb.cc] Error 1

@Nitya05
Copy link
Author

Nitya05 commented Jul 19, 2018

Okay, thanks. This worked.

@mpoullet
Copy link
Contributor

mpoullet commented Oct 30, 2018

The option php_metadata_namespace is only known to protoc version 3.6.0 and above. gRPC v1.11.0 used in build.sh only generates protoc version 3.5.0. Using e.g. gRPC v1.15.0 fixes this issue properly by building protoc version 3.6.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants