Skip to content

Commit bb0b272

Browse files
evicyV8-internal LUCI CQ
authored and
V8-internal LUCI CQ
committed
[wasm][table] Use WasmTableType type info in WasmLifter for import section
Probably it was forgotten and we used hardcoded limits and table type when lifting the tables in the import section. Change-Id: Ic57abb576a20a8648ed11e78a2098d43850064f4 Reviewed-on: https://chrome-internal-review.googlesource.com/c/v8/fuzzilli/+/7977210 Commit-Queue: Eva Herencsárová <[email protected]> Reviewed-by: Carl Smith <[email protected]>
1 parent 5e7425d commit bb0b272

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

Sources/Fuzzilli/Lifting/WasmLifter.swift

+4-6
Original file line numberDiff line numberDiff line change
@@ -489,12 +489,10 @@ public class WasmLifter {
489489
continue
490490
}
491491
if type.Is(.object(ofGroup: "WasmTable")) {
492-
// let tableType = type.wasmTableType!.tableType
493-
let tableType = ILType.wasmExternRef
494-
// let minSize = type.wasmTableType!.minSize
495-
let minSize = 10
496-
// let maxSize = type.wasmTableType!.maxSize
497-
let maxSize: Int? = 20
492+
let tableType = type.wasmTableType!.elementType
493+
assert(tableType == ILType.wasmExternRef)
494+
let minSize = type.wasmTableType!.limits.min
495+
let maxSize = type.wasmTableType!.limits.max
498496
temp += Data([0x1])
499497
temp += ILTypeMapping[tableType]!
500498
if let maxSize = maxSize {

Tests/FuzzilliTests/WasmTests.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -408,7 +408,7 @@ class WasmFoundationTests: XCTestCase {
408408
let fuzzer = makeMockFuzzer(config: liveTestConfig, environment: JavaScriptEnvironment())
409409
let b = fuzzer.makeBuilder()
410410

411-
let javaScriptTable = b.createWasmTable(elementType: .wasmExternRef, limits: Limits(min: 10, max: 20))
411+
let javaScriptTable = b.createWasmTable(elementType: .wasmExternRef, limits: Limits(min: 5, max: 25))
412412

413413
let object = b.createObject(with: ["a": b.loadInt(41), "b": b.loadInt(42)])
414414

0 commit comments

Comments
 (0)