Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use Get*() methods when reading proto values #319

Open
yuryu opened this issue Dec 24, 2021 · 1 comment
Open

refactor: use Get*() methods when reading proto values #319

yuryu opened this issue Dec 24, 2021 · 1 comment

Comments

@yuryu
Copy link
Member

yuryu commented Dec 24, 2021 •
edited
Loading

protos support both direct variable access and Get*() methods. Prefer getter methods where possible.
@yuryu yuryu mentioned this issue Jun 10, 2022
Merged
@yuryu
Copy link
Member Author

yuryu commented Jun 10, 2022

After doing some research, these getters are safer and shows the intent clearer. I'll change this bug to the opposite.

@yuryu yuryu changed the title refactor: use variables instead of Get*() methods for proto refactor: use Get*() methods when reading proto values Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yuryu