Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1 release prep #4

Open
davelab6 opened this issue Mar 14, 2022 · 4 comments
Open

v1 release prep #4

davelab6 opened this issue Mar 14, 2022 · 4 comments
Assignees

Comments

@davelab6
Copy link
Member

@aaronbell emailed me:

I’ve updated the main UD Gothic and UD Mincho projects with the new repro format and build process. All fonts are building and, to my knowledge, match existing functionality of the previous fonts (also the diffenator did not show any unexpected changes). The getting the repositories working right took a little longer than I expected as the UFR process has changed a bit since I last looked at it. 😀

Fantastic!

Some notes:

  1. I’ve gotten the fonts building with the UFR format (with some modifications), and gh-pages updates with proofing tools. Fonts build to artifacts (and can be tagged for release and PR).

Great!

  1. The script that builds these fonts relies on pyftmerge, which offered the best way to add glyphs to the fonts programmatically without impacting the structure / functionality of the original. While there were some metadata items that needed to be corrected after merge, everything is building as expected now.

build.py looks excellent. Please report the fontmake/ttfautohint not working issue in https://github.com/googlefonts/fontmake/issues

  1. The added glyphs have been hinted using TTFautohint (on symbol mode) in order to ensure that those glyphs have some hinting, rather than being left unhinted with hinting turned on.

Nice!

  1. There are a number of fails in FontBakery, but I do not believe any are problematic:

🔥 FAIL: Check Google Fonts Latin Core glyph coverage.
One character is depreciated and FB has not been updated as of yet.
🔥 FAIL: Check name table: FONTFAMILYNAME entries.
🔥 FAIL: Check name table: FULLFONTNAME entries.
These both relate to the use of Japanese localized names, as well as expecting "BIZUDGothic" rather than "BIZ UDGothic" which is required for compatibility reasons.

@felipesanches can add these to the fontbakery gf profile hard coded exceptions list.

🔥 FAIL: Font enables smart dropout control in "prep" table instructions?
I didn't want to modify the hinting instructions, but this can be updated as necessary.

OK

🔥 FAIL: Check font follows the Google Fonts CJK vertical metric schema
FB check expects .88xUPM, which would be 1802.24 and -245.76. This font has been set as 1802 and -246.

@felipesanches I guess this check needs to be refined, maybe lacking a simple round()?

🔥 FAIL: Font has correct post table version?
Font sources have version 3 post table. No way to easily swap back to version 2.

That's fine, recently we've been discussing allowing v3 anyway.

  1. I’ve added a base description and “about” to the README for each font found on the web, but it may be worth having Morisawa review (and update!) as necessary.

For sure

If you have any questions / concerns about these as they currently stand, please let me know. Else, I will proceed with creating the V1.0 release and submitting a PR to GF.

Thanks!!

@aaronbell
Copy link
Collaborator

Thanks Dave.

For @felipesanches' reference:
Non-ASCII font name - fonttools/fontbakery#3089
Fractional metrics for CJK - fonttools/fontbakery#3645

@davelab6
Copy link
Member Author

@felipesanches to close this, please confirm the above hard coding request is done :)

@felipesanches
Copy link
Member

Not done yet. But I'll re-prioritize this.

@felipesanches
Copy link
Member

felipesanches commented Apr 21, 2022

@davelab6:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants