Skip to content

Commit 1b2457f

Browse files
vertex-sdk-botcopybara-github
authored andcommitted
chore: Feature Store - Fixed a bug in the create_feature_monitor_job function
PiperOrigin-RevId: 704458748
1 parent 05f27b6 commit 1b2457f

File tree

2 files changed

+3
-36
lines changed

2 files changed

+3
-36
lines changed

tests/unit/vertexai/test_feature_monitor.py

Lines changed: 1 addition & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -84,10 +84,8 @@ def create_feature_monitor_job_mock():
8484
FeatureRegistryServiceClient,
8585
"create_feature_monitor_job",
8686
) as create_feature_monitor_job_mock:
87-
create_feature_monitor_job_lro_mock = mock.Mock(ga_operation.Operation)
88-
create_feature_monitor_job_lro_mock.result.return_value = _TEST_FG1_FMJ1
8987
create_feature_monitor_job_mock.return_value = (
90-
create_feature_monitor_job_lro_mock
88+
_TEST_FG1_FMJ1
9189
)
9290
yield create_feature_monitor_job_mock
9391

@@ -299,27 +297,6 @@ def test_create_feature_monitor_job(
299297
labels=_TEST_FG1_FMJ1_LABELS,
300298
)
301299

302-
fm_logger_mock.assert_has_calls(
303-
[
304-
call("Creating FeatureMonitorJob"),
305-
call(
306-
f"Create FeatureMonitorJob backing LRO:"
307-
f" {create_feature_monitor_job_mock.return_value.operation.name}"
308-
),
309-
call(
310-
"FeatureMonitorJob created. Resource name:"
311-
" projects/test-project/locations/us-central1/featureGroups/"
312-
"my_fg1/featureMonitors/my_fg1_fm1/featureMonitorJobs/1234567890"
313-
),
314-
call("To use this FeatureMonitorJob in another session:"),
315-
call(
316-
"feature_monitor_job = aiplatform.FeatureMonitorJob("
317-
"'projects/test-project/locations/us-central1/featureGroups/"
318-
"my_fg1/featureMonitors/my_fg1_fm1/featureMonitorJobs/1234567890')"
319-
),
320-
]
321-
)
322-
323300

324301
def test_get_feature_monitor_job(
325302
get_feature_monitor_mock, get_feature_monitor_job_mock

vertexai/resources/preview/feature_store/feature_monitor.py

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ class FeatureMonitor(base.VertexAiResourceNounWithFutureManager):
3636
_resource_noun = "feature_monitors"
3737
_getter_method = "get_feature_monitor"
3838
_list_method = "list_feature_monitors"
39-
_delete_method = "delete_feature_monitors"
39+
_delete_method = "delete_feature_monitor"
4040
_parse_resource_name_method = "parse_feature_monitor_path"
4141
_format_resource_name_method = "feature_monitor_path"
4242
_gca_resource: gca_feature_monitor.FeatureMonitor
@@ -250,7 +250,7 @@ def create_feature_monitor_job(
250250
location=location, credentials=credentials
251251
)
252252

253-
create_feature_monitor_job_lro = api_client.select_version(
253+
created_feature_monitor_job = api_client.select_version(
254254
"v1beta1"
255255
).create_feature_monitor_job(
256256
parent=self.resource_name,
@@ -259,16 +259,6 @@ def create_feature_monitor_job(
259259
timeout=create_request_timeout,
260260
)
261261

262-
_LOGGER.log_create_with_lro(
263-
self.FeatureMonitorJob, create_feature_monitor_job_lro
264-
)
265-
266-
created_feature_monitor_job = create_feature_monitor_job_lro.result()
267-
268-
_LOGGER.log_create_complete(
269-
self.FeatureMonitorJob, created_feature_monitor_job, "feature_monitor_job"
270-
)
271-
272262
feature_monitor_job_obj = self.FeatureMonitorJob(
273263
name=created_feature_monitor_job.name,
274264
project=project,

0 commit comments

Comments
 (0)