Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: binary size increase by 20Mb after the commit 9ad83248a7049c82580bc45d9685c329811bce88 #11448

Open
f41gh7 opened this issue Jan 14, 2025 · 2 comments
Assignees
Labels
api: storage Issues related to the Cloud Storage API. type: question Request for information or clarification. Not an issue.

Comments

@f41gh7
Copy link

f41gh7 commented Jan 14, 2025

We at VictoriaMetrics use cloud.google.com/go/storage package here for interaction with from Google Storage.
This dependency increased VictoriaMetrics backup/restore binaries size by 20Mb after we upgraded cloud.google.com/go/storage dependency from v1.43.0 to v1.44.0+ . This is more than 25% of binary size increase. We try hard keeping dependency bloat at minimum - see https://valyala.medium.com/stripping-dependency-bloat-in-victoriametrics-docker-image-983fb5912b0d . So it would be great if you could reduce the storage dependency size to pre-v1.44.0 sizes.

Related PR:
#10757

@f41gh7 f41gh7 added the triage me I really want to be triaged. label Jan 14, 2025
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Jan 14, 2025
@tritone tritone added type: question Request for information or clarification. Not an issue. and removed triage me I really want to be triaged. labels Jan 14, 2025
@tritone
Copy link
Contributor

tritone commented Jan 14, 2025

As mentioned in the linked PR and in the release notes for v1.44.0, these dependencies can be omitted (if you are not using NewGRPCClient by using the build tag disable_grpc_modules.

Does this resolve the issue for you?

@f41gh7
Copy link
Author

f41gh7 commented Jan 15, 2025

Thanks for the suggestion, sorry I missed that point from PR description. Binary compiled with disable_grpc_modules is bigger by ~3Mb compared to v1.43.0 release. Which is better, but not ideal. But I think it solves problem for us.

A side note, single import of cloud.google.com/go/storage package increases binary size by ~22Mb before v1.44.0 and by ~40Mb after v1.44.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. type: question Request for information or clarification. Not an issue.
Projects
None yet
Development

No branches or pull requests

2 participants