feat: Introduce per-credential specific load methods #1827
Merged
+195
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lqiu96
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
lqiu96
commented
Oct 23, 2025
| String fileType = extractFromJson(fileContents, "type"); | ||
| if (fileType.equals(GoogleCredentialsInfo.EXTERNAL_ACCOUNT_CREDENTIALS.getFileType())) { | ||
| try { | ||
| return fromJson(fileContents, transportFactory); |
Member
Author
There was a problem hiding this comment.
@zhumin8 Talked with Sai and ExternalAccountCredential.fromStream() branching off to creating the subtypes is fine to keep.
zhumin8
approved these changes
Oct 31, 2025
| String fileType = extractFromJson(fileContents, "type"); | ||
| if (fileType.equals(GoogleCredentialsInfo.EXTERNAL_ACCOUNT_CREDENTIALS.getFileType())) { | ||
| try { | ||
| return fromJson(fileContents, transportFactory); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the alternatives for each Credential subclass for
GoogleCredentials.fromStream()