Skip to content

Add support for JCA Provider to ServiceAccountCredentials #410

@stian-svedenborg-gul-katt

Description

The current API for ServiceAccountCredentials does not support explicitly setting a Provider. (This is true for all Credentials implementing ServiceAccountSigner, but changing it consistently for all these should also incorporate changes to com.google.api.client.json.webtoken.JsonWebSignature in my opinion).

The current behaviour relies on JCA to always yield the correct provider for java.security.Signature regardless of how the key is stored. When the key is stored in a KeyVault or on a HSM this assumption fails. This is a design limitation in the JCA and requires the use of explicit providers.

I have a patch that fixes the issue for ServiceAccountCredentials, and suggest that similar work is done on the other GoogleCredentials implementations.

Environment details

  • OS: All
  • Java version: 1+
  • google-auth-library-java version(s): All versions before 0a57cd5

Steps to reproduce

  1. Add another JCA provider providing the "RSAwithSHA256" signature algorithm to the stack bottom of the stack.
  2. Create an opaque private key.
  3. Use this key for signing the authentication assertions.

Metadata

Metadata

Assignees

No one assigned

    Labels

    type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions