Deny other Clippy lints?

[joshlf]

Currently, we deny clippy::indexing_slicing. Should we deny others? So far, I've found:

• arithmetic_side_effects
• alloc_instead_of_core
• std_instead_of_core

The time crate has a good list.

We're tracking undocumented_unsafe_blocks separately in #61 since it will likely be a substantial change on its own.

[AntoniosBarotsis]

I know this is closed but in case you are not aware, you can also put all your lints in a cargo config file so that they are grouped together and not in your source code.

I am doing that in a project I am working on here in case you are interested. Perhaps you know this already, just making sure!

Edit: I see that you defined some lints specifically for tests only, not sure if that is possible in the config file but it sounds like it should.

[joshlf]

Oh interesting. What's the advantage of doing that over doing it in source code?

[AntoniosBarotsis]

In my case, back when I was using macros in my source code, I found some weird cases where the lints would not work properly between my main and my lib files. Other than that, it's just a bit easier to manage IMO but definitely not a big deal 👍

[joshlf]

Oh gotcha. Good to know about! Not sure we need it now, but I could see a future in which we want to synchronize across, e.g., zerocopy and zerocopy-derive, or across library code and code in tests/, etc.

[joshlf]

@AntoniosBarotsis in case you hadn't seen this, I just stumbled across the existence of clippy.toml files.

[AntoniosBarotsis]

I'm assuming you meant clippy.toml 😄. I think I tried that at first but realized that there was quite a few limitations to it so I switched to what I mentioned above with the config.toml file instead.

[joshlf]

Hahaha yes I did.