Skip to content

Commit 07854bc

Browse files
authored
[CI] Remove CARGO_NET_RETRY override (#324)
The caching introduced in #302 fixes the issue that this override was meant to address, so it's no longer necessary.
1 parent 4df931d commit 07854bc

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

.github/workflows/ci.yml

-10
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,6 @@ permissions: read-all
1111

1212
env:
1313
CARGO_TERM_COLOR: always
14-
# Increased from the default value of 3 in order to address #295. As of that issue's
15-
# writing, we were experiencing a few failures per 149 jobs due to network timeouts.
16-
# This implies a failure rate of (very roughly) 1 in 50. Assuming statistically
17-
# independent network failures (probably a bad assumption, but we can't really do
18-
# better without a lot more investigating), every subsequent 3 retries should reduce
19-
# the incidence of failures 50-fold. Setting this to 9 should result in a failure
20-
# rate of 1 in 125,000. Assuming 149 jobs per PR, we should expect at least one
21-
# failure per set of 149 jobs to occur with 1 - (1 - (1/125000))^149 = 0.001%
22-
# probability, which is plenty low enough to not meaningfully impact development.
23-
CARGO_NET_RETRY: 9
2414
RUSTFLAGS: -Dwarnings
2515
RUSTDOCFLAGS: -Dwarnings
2616
# `ZC_NIGHTLY_XXX` are flags that we add to `XXX` only on the nightly

0 commit comments

Comments
 (0)