You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In 9043 we added the ability to define staging ESLint rules that only apply to newly committed files through husky, to avoid having to complete large refactors when adding new rules.
Currently staged rules are added to the main eslint-plugin-sitekit which means we have to disable the rules in the main ruleset for every staged rule.
Instead we could create a separate ruleset (eg. eslint-plugin-sitekit-staging) that is only brought into the .eslintrc.staged.json config and applied to new changes.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
Test Coverage
QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered:
Another thing to possibly consider here or in a new ticket is that the staged rules don't currently get highlighted within VSCode for me because of how it detects the ruleset. It would be good to be able to see staged rules in the editor to catch them early during coding.
Although developers use different setups so perhaps this is out of scope of core plugin changes and down to each developer to configure.
Feature Description
In 9043 we added the ability to define staging ESLint rules that only apply to newly committed files through husky, to avoid having to complete large refactors when adding new rules.
Currently staged rules are added to the main
eslint-plugin-sitekit
which means we have to disable the rules in the main ruleset for every staged rule.site-kit-wp/.eslintrc.json
Lines 181 to 182 in 3fb6f47
Instead we could create a separate ruleset (eg.
eslint-plugin-sitekit-staging
) that is only brought into the.eslintrc.staged.json
config and applied to new changes.Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
Test Coverage
QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: