Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using bundlesize as a "check" #1084

Closed
aaemnnosttv opened this issue Jan 30, 2020 · 1 comment
Closed

Consider using bundlesize as a "check" #1084

aaemnnosttv opened this issue Jan 30, 2020 · 1 comment
Labels
Type: Enhancement Improvement of an existing feature

Comments

@aaemnnosttv
Copy link
Collaborator

Feature Description

We currently run bundlesize to ensure webpack-built bundles are within reasonable sizes during our JS Tests that run on Travis.

This works fine as a pass/fail but is currently implemented as a pass/fail as part of the Travis build as a whole. The executable also supports a closer integration with GitHub by integrating as a check that runs on all PRs. This could be required to pass or not for merging separately from the Travis build it runs on.

The main benefit seems to be that it makes bundle size changes introduced by a PR more visible

Example from the readme:


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Changelog entry

@aaemnnosttv aaemnnosttv added the Type: Enhancement Improvement of an existing feature label Jan 30, 2020
@tofumatt
Copy link
Collaborator

This is a duplicate of #2539. In fact, #2539 is a duplicate of this, but since that one has a PR for it and discussions, let's close this and keep working on this issue in #2539.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants