You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We currently run bundlesize to ensure webpack-built bundles are within reasonable sizes during our JS Tests that run on Travis.
This works fine as a pass/fail but is currently implemented as a pass/fail as part of the Travis build as a whole. The executable also supports a closer integration with GitHub by integrating as a check that runs on all PRs. This could be required to pass or not for merging separately from the Travis build it runs on.
The main benefit seems to be that it makes bundle size changes introduced by a PR more visible
Example from the readme:
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
Changelog entry
The text was updated successfully, but these errors were encountered:
This is a duplicate of #2539. In fact, #2539 is a duplicate of this, but since that one has a PR for it and discussions, let's close this and keep working on this issue in #2539.
Feature Description
We currently run
bundlesize
to ensure webpack-built bundles are within reasonable sizes during our JS Tests that run on Travis.This works fine as a pass/fail but is currently implemented as a pass/fail as part of the Travis build as a whole. The executable also supports a closer integration with GitHub by integrating as a check that runs on all PRs. This could be required to pass or not for merging separately from the Travis build it runs on.
The main benefit seems to be that it makes bundle size changes introduced by a PR more visible
Example from the readme:
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
Changelog entry
The text was updated successfully, but these errors were encountered: