Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move js dependencies required for E2E tests into their own workspace #10013

Open
4 tasks
eugene-manuilov opened this issue Jan 13, 2025 · 1 comment
Open
4 tasks
Labels
P1 Medium priority QA: Eng Requires specialized QA by an engineer Type: Infrastructure Engineering infrastructure & tooling

Comments

@eugene-manuilov
Copy link
Collaborator

Feature Description

In order to resolve js dependency conflicts, we need to separate dependencies used by different parts of our project and put them into separate workspaces. The first part of this process is to move js dependencies needed for E2E tests to run into a separate workspace.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The package.json file is updated to have the workspaces section with the only one workspace for E2E tests.
  • JavaScript dependencies that are needed for E2E tests to function properly are moved to the new workspace.
  • GitHub actions for E2E tests are updated accordingly to continue running E2E tests for all PRs.

Implementation Brief

  • Update the package.json file to have the new workspaces section using [ "tests/e2e" ] as its value.
  • Create a new package.json file in the tests/e2e folder. You can use npm init -w ./tests/e2e to do that.
    • Copy over e2e commands from the main package.json file into the new one.
  • Scan all dependencies that we have in the main package.json file and move all dependecies that are used in e2e tests to its own package by uninstalling them in the main package.json file and installing with -w ./tests/e2e argument to specify the correct workspace.
  • Update the pacakge.json file to proxy e2e commands to the correct workspace using the npm run ... -w ./tests/e2e approach.

Test Coverage

  • N/A

QA Brief

Changelog entry

@eugene-manuilov eugene-manuilov added P1 Medium priority QA: Eng Requires specialized QA by an engineer Type: Enhancement Improvement of an existing feature Type: Infrastructure Engineering infrastructure & tooling and removed Type: Enhancement Improvement of an existing feature labels Jan 13, 2025
@techanvil techanvil self-assigned this Jan 15, 2025
@techanvil
Copy link
Collaborator

Nice work here @eugene-manuilov, this looks like a good way to get us started with an incremental move to NPM workspaces.

IB ✅

@techanvil techanvil removed their assignment Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Medium priority QA: Eng Requires specialized QA by an engineer Type: Infrastructure Engineering infrastructure & tooling
Projects
None yet
Development

No branches or pull requests

2 participants