Skip to content

Commit 55bb007

Browse files
authored
Merge pull request #7900 from google/enhancement/7720-update-cd-descriptions
2 parents 87ca642 + 8becb61 commit 55bb007

File tree

1 file changed

+12
-22
lines changed

1 file changed

+12
-22
lines changed

assets/js/modules/analytics-4/datastore/constants.js

+12-22
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,6 @@
1616
* limitations under the License.
1717
*/
1818

19-
/**
20-
* WordPress dependencies
21-
*/
22-
import { __ } from '@wordpress/i18n';
23-
2419
export const MODULES_ANALYTICS_4 = 'modules/analytics-4';
2520

2621
export const PROPERTY_CREATE = 'property_create';
@@ -40,38 +35,33 @@ export const ENHANCED_MEASUREMENT_SHOULD_DISMISS_ACTIVATION_BANNER =
4035

4136
export const FORM_CUSTOM_DIMENSIONS_CREATE = 'analytics4CustomDimensionsCreate';
4237

38+
// Note: names and descriptions are not translated as these are not surfaced in Site Kit
39+
// and are also subject to hard limits on the length which would be unpredictable if translated.
40+
// See https://developers.google.com/analytics/devguides/config/admin/v1/rest/v1beta/properties.customDimensions#CustomDimension
4341
export const CUSTOM_DIMENSION_DEFINITIONS = {
4442
googlesitekit_post_date: {
4543
parameterName: 'googlesitekit_post_date',
46-
displayName: __( 'WordPress Post Creation Date', 'google-site-kit' ),
47-
description: __(
48-
'Date of which this post was published',
49-
'google-site-kit'
50-
),
44+
displayName: 'WordPress Post Date',
45+
description: 'Created by Site Kit: Date when a post was published',
5146
scope: 'EVENT',
5247
},
5348
googlesitekit_post_author: {
5449
parameterName: 'googlesitekit_post_author',
55-
displayName: __( 'WordPress Post Author', 'google-site-kit' ),
56-
description: __(
57-
'User ID of the author for this post',
58-
'google-site-kit'
59-
),
50+
displayName: 'WordPress Post Author',
51+
description: 'Created by Site Kit: WordPress name of the post author',
6052
scope: 'EVENT',
6153
},
6254
googlesitekit_post_categories: {
6355
parameterName: 'googlesitekit_post_categories',
64-
displayName: __( 'WordPress Post Categories', 'google-site-kit' ),
65-
description: __(
66-
'Comma-separated list of category IDs assigned to this post',
67-
'google-site-kit'
68-
),
56+
displayName: 'WordPress Post Categories',
57+
description:
58+
'Created by Site Kit: Names of categories assigned to a post',
6959
scope: 'EVENT',
7060
},
7161
googlesitekit_post_type: {
7262
parameterName: 'googlesitekit_post_type',
73-
displayName: __( 'WordPress Post Type', 'google-site-kit' ),
74-
description: __( 'Content type for this post', 'google-site-kit' ),
63+
displayName: 'WordPress Post Type',
64+
description: 'Created by Site Kit: Content type of a post',
7565
scope: 'EVENT',
7666
},
7767
};

0 commit comments

Comments
 (0)