Skip to content

Commit a06f052

Browse files
authored
gitoxide: Use updated nightly to fix serde error (#12512)
Since around GitoxideLabs/gitoxide#1536, fuzzing is broken for `gitoxide` due to an error related to `serde`. As shown there and in GitoxideLabs/gitoxide#1596, the error is: error[E0658]: `#[diagnostic]` attribute name space is experimental --> /rust/registry/src/index.crates.io-6f17d22bba15001f/serde-1.0.210/src/de/mod.rs:536:5 | 536 | diagnostic::on_unimplemented( | ^^^^^^^^^^ | = note: see issue #111996 <rust-lang/rust#111996> for more information = help: add `#![feature(diagnostic_namespace)]` to the crate attributes to enable = note: this compiler was built on 2024-02-11; consider upgrading it if it is out of date Since rust-lang/rust#111996 is closed as completed, and similar errors appear to have been fixed in oss-fuzz for other projects by using the latest nightly toolchain, this makes the same change for `gitoxide` as was made in: - #12404 for `starlark-rust` - #12409 for `rhai` See also: - #12410 - serde-rs/serde#2770 cc @Byron
1 parent e5978be commit a06f052

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

projects/gitoxide/Dockerfile

+1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
FROM gcr.io/oss-fuzz-base/base-builder-rust
1818
RUN git clone --depth 1 https://github.com/Byron/gitoxide.git gitoxide
19+
RUN rustup update nightly
1920
WORKDIR gitoxide
2021
RUN rustup component add rust-src
2122
COPY build.sh $SRC/

projects/gitoxide/build.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ for CRATE_DIR in ${FUZZ_CRATE_DIRS[@]};
2525
do
2626
echo "Building crate: $CRATE_DIR"
2727
cd $CRATE_DIR
28-
cargo fuzz build -O --debug-assertions
28+
cargo +nightly fuzz build -O --debug-assertions
2929
FUZZ_TARGET_OUTPUT_DIR=$CARGO_BUILD_TARGET_DIR/x86_64-unknown-linux-gnu/release
3030
for f in fuzz/fuzz_targets/*.rs
3131
do

0 commit comments

Comments
 (0)