Skip to content

Commit e48e42e

Browse files
committed
style(secops): adhere strictly to Google Python Style Guide for logging formatting in case and alert management
1 parent e709fd9 commit e48e42e

2 files changed

Lines changed: 22 additions & 22 deletions

File tree

server/secops/secops_mcp/tools/case_alert_management.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ async def list_case_alerts(
9292
}
9393
return response.json()
9494
except Exception as e:
95-
logger.error(f"Error listing case alerts for case {case_id}: {e}")
95+
logger.error("Error listing case alerts for case %s: %s", case_id, e)
9696
return {"error": f"Failed to list case alerts: {str(e)}"}
9797

9898

@@ -132,7 +132,7 @@ async def get_case_alert(
132132
}
133133
return response.json()
134134
except Exception as e:
135-
logger.error(f"Error getting case alert {alert_id}: {e}")
135+
logger.error("Error getting case alert %s: %s", alert_id, e)
136136
return {"error": f"Failed to get case alert: {str(e)}"}
137137

138138

@@ -212,7 +212,7 @@ async def update_case_alert(
212212
}
213213
return response.json()
214214
except Exception as e:
215-
logger.error(f"Error updating case alert {alert_id}: {e}")
215+
logger.error("Error updating case alert %s: %s", alert_id, e)
216216
return {"error": f"Failed to update case alert: {str(e)}"}
217217

218218

@@ -256,7 +256,7 @@ async def change_alert_priority(
256256
region=region,
257257
)
258258
except Exception as e:
259-
logger.error(f"Error changing alert priority: {e}")
259+
logger.error("Error changing alert priority: %s", e)
260260
return {"error": f"Failed to change alert priority: {str(e)}"}
261261

262262

@@ -304,7 +304,7 @@ async def set_alert_custom_fields(
304304
region=region,
305305
)
306306
except Exception as e:
307-
logger.error(f"Error setting alert custom fields: {e}")
307+
logger.error("Error setting alert custom fields: %s", e)
308308
return {"error": f"Failed to set alert custom fields: {str(e)}"}
309309

310310

@@ -349,7 +349,7 @@ async def move_case_alert(
349349
}
350350
return response.json() if response.text else {"status": "SUCCESS", "message": f"Moved alert {short_alert_id} to case {short_dest_case_id}"}
351351
except Exception as e:
352-
logger.error(f"Error moving case alert: {e}")
352+
logger.error("Error moving case alert: %s", e)
353353
return {"error": f"Failed to move case alert: {str(e)}"}
354354

355355

@@ -391,7 +391,7 @@ async def add_alert_tag(
391391
}
392392
return response.json() if response.text else {"status": "SUCCESS", "message": f"Added tag '{tag}' to alert"}
393393
except Exception as e:
394-
logger.error(f"Error adding tag to alert: {e}")
394+
logger.error("Error adding tag to alert: %s", e)
395395
return {"error": f"Failed to add tag to alert: {str(e)}"}
396396

397397

@@ -433,5 +433,5 @@ async def remove_alert_tag(
433433
}
434434
return response.json() if response.text else {"status": "SUCCESS", "message": f"Removed tag '{tag}' from alert"}
435435
except Exception as e:
436-
logger.error(f"Error removing tag from alert: {e}")
436+
logger.error("Error removing tag from alert: %s", e)
437437
return {"error": f"Failed to remove tag from alert: {str(e)}"}

server/secops/secops_mcp/tools/case_management.py

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ async def list_cases(
9595
}
9696
return response.json()
9797
except Exception as e:
98-
logger.error(f"Error listing cases: {e}")
98+
logger.error("Error listing cases: %s", e)
9999
return {"error": f"Failed to list cases: {str(e)}"}
100100

101101

@@ -139,7 +139,7 @@ async def get_case(
139139
}
140140
return response.json()
141141
except Exception as e:
142-
logger.error(f"Error getting case {case_id}: {e}")
142+
logger.error("Error getting case %s: %s", case_id, e)
143143
return {"error": f"Failed to get case: {str(e)}"}
144144

145145

@@ -220,7 +220,7 @@ async def update_case(
220220
}
221221
return response.json()
222222
except Exception as e:
223-
logger.error(f"Error updating case {case_id}: {e}")
223+
logger.error("Error updating case %s: %s", case_id, e)
224224
return {"error": f"Failed to update case: {str(e)}"}
225225

226226

@@ -268,7 +268,7 @@ async def change_case_priority(
268268
}
269269
return {"status": "SUCCESS", "message": f"Updated priority to {p_upper} for {len(full_names)} case(s)"}
270270
except Exception as e:
271-
logger.error(f"Error changing case priority: {e}")
271+
logger.error("Error changing case priority: %s", e)
272272
return {"error": f"Failed to change case priority: {str(e)}"}
273273

274274

@@ -313,7 +313,7 @@ async def change_case_stage(
313313
}
314314
return {"status": "SUCCESS", "message": f"Updated stage to '{stage}' for {len(full_names)} case(s)"}
315315
except Exception as e:
316-
logger.error(f"Error changing case stage: {e}")
316+
logger.error("Error changing case stage: %s", e)
317317
return {"error": f"Failed to change case stage: {str(e)}"}
318318

319319

@@ -366,7 +366,7 @@ async def assign_case(
366366
assigned_target = assignee or soc_role
367367
return {"status": "SUCCESS", "message": f"Assigned {len(full_names)} case(s) to {assigned_target}"}
368368
except Exception as e:
369-
logger.error(f"Error assigning case: {e}")
369+
logger.error("Error assigning case: %s", e)
370370
return {"error": f"Failed to assign case: {str(e)}"}
371371

372372

@@ -421,7 +421,7 @@ async def set_custom_case_fields(
421421
}
422422
return response.json()
423423
except Exception as e:
424-
logger.error(f"Error setting custom case fields: {e}")
424+
logger.error("Error setting custom case fields: %s", e)
425425
return {"error": f"Failed to set custom case fields: {str(e)}"}
426426

427427

@@ -461,7 +461,7 @@ async def add_case_tag(
461461
}
462462
return response.json() if response.text else {"status": "SUCCESS", "message": f"Added tag '{tag}'"}
463463
except Exception as e:
464-
logger.error(f"Error adding tag to case: {e}")
464+
logger.error("Error adding tag to case: %s", e)
465465
return {"error": f"Failed to add tag: {str(e)}"}
466466

467467

@@ -501,7 +501,7 @@ async def remove_case_tag(
501501
}
502502
return response.json() if response.text else {"status": "SUCCESS", "message": f"Removed tag '{tag}'"}
503503
except Exception as e:
504-
logger.error(f"Error removing tag from case: {e}")
504+
logger.error("Error removing tag from case: %s", e)
505505
return {"error": f"Failed to remove tag: {str(e)}"}
506506

507507

@@ -547,7 +547,7 @@ async def add_case_insight(
547547
}
548548
return response.json()
549549
except Exception as e:
550-
logger.error(f"Error adding insight to case: {e}")
550+
logger.error("Error adding insight to case: %s", e)
551551
return {"error": f"Failed to add insight: {str(e)}"}
552552

553553

@@ -587,7 +587,7 @@ async def pause_case_sla(
587587
}
588588
return {"status": "SUCCESS", "message": f"Paused SLA on case {case_id}"}
589589
except Exception as e:
590-
logger.error(f"Error pausing SLA on case: {e}")
590+
logger.error("Error pausing SLA on case: %s", e)
591591
return {"error": f"Failed to pause SLA: {str(e)}"}
592592

593593

@@ -625,7 +625,7 @@ async def resume_case_sla(
625625
}
626626
return {"status": "SUCCESS", "message": f"Resumed SLA on case {case_id}"}
627627
except Exception as e:
628-
logger.error(f"Error resuming SLA on case: {e}")
628+
logger.error("Error resuming SLA on case: %s", e)
629629
return {"error": f"Failed to resume SLA: {str(e)}"}
630630

631631

@@ -680,7 +680,7 @@ async def close_case(
680680
}
681681
return {"status": "SUCCESS", "message": f"Closed {len(full_names)} case(s)"}
682682
except Exception as e:
683-
logger.error(f"Error closing case(s): {e}")
683+
logger.error("Error closing case(s): %s", e)
684684
return {"error": f"Failed to close case: {str(e)}"}
685685

686686

@@ -723,5 +723,5 @@ async def reopen_case(
723723
}
724724
return {"status": "SUCCESS", "message": f"Reopened {len(full_names)} case(s)"}
725725
except Exception as e:
726-
logger.error(f"Error reopening case(s): {e}")
726+
logger.error("Error reopening case(s): %s", e)
727727
return {"error": f"Failed to reopen case: {str(e)}"}

0 commit comments

Comments
 (0)