Optimize @AndroidIncompatible annotations.

Largely, this is about enabling tests that were unlocked by our upgrade to the emulator we test under now that we are on a minSdkVersion of 24. That upgrade both fixed bugs and improved performance of some excessively slow methods.

But I also took this opportunity to be more systematic about which tests we consider "too slow" to run under Android. I believe that what I did was (keeping in mind that test runtime can vary from run to run):
- If a test takes ~30s+, add/keep `@AndroidIncompatible`. Otherwise, consider it "fast enough."
- If a test takes ~15s+, add/keep/update a comment about its approximate runtime.
- But make an unprincipled exception for `Utf8Test.testIsWellFormed_3Bytes`, which takes ~70s but felt some combination of "important" and "possible to imagine behavior differences from rogue optimizations." (Maybe vaguely compare b/262383185??)

RELNOTES=n/a
PiperOrigin-RevId: 984013883

Author: cpovirk

android/guava-testlib/test/com/google/common/testing/FreshValueGeneratorTest.java

@@ -118,7 +118,6 @@
 @NullUnmarked
 public class FreshValueGeneratorTest extends TestCase {
 
-  @AndroidIncompatible // problem with equality of Type objects?
   public void testFreshInstance() {
     assertFreshInstances(
         String.class,
@@ -429,7 +428,6 @@ public void testEnums() {
     assertFreshInstance(new TypeToken<List<TwoConstantEnum>>() {}, 2);
   }
 
-  @AndroidIncompatible // problem with equality of Type objects?
   public void testGoogleOptional() {
     FreshValueGenerator generator = new FreshValueGenerator();
     assertEquals(

android/guava-tests/test/com/google/common/base/FunctionsTest.java

@@ -421,8 +421,6 @@ public void testNulls() throws Exception {
 
   @J2ktIncompatible
   @GwtIncompatible // reflection
-  @AndroidIncompatible // TODO(cpovirk): ClassNotFoundException: com.google.common.base.Function
-  // (I suspect that this and the other similar failures happen with ArbitraryInstances proxies.)
   public void testEqualsAndSerializable() throws Exception {
     new ClassSanityTester().forAllPublicStaticMethods(Functions.class).testEqualsAndSerializable();
   }

android/guava-tests/test/com/google/common/base/PredicatesTest.java

@@ -909,7 +909,6 @@ public void testNulls() throws Exception {
 
   @J2ktIncompatible
   @GwtIncompatible // reflection
-  @AndroidIncompatible // TODO(cpovirk): ClassNotFoundException: com.google.common.base.Function
   public void testEqualsAndSerializable() throws Exception {
     new ClassSanityTester().forAllPublicStaticMethods(Predicates.class).testEqualsAndSerializable();
   }

android/guava-tests/test/com/google/common/base/SplitterTest.java

@@ -359,7 +359,6 @@ public void testPatternSplitWithDoubleDelimiterOmitEmptyStrings() {
 
   @J2ktIncompatible // Kotlin Native's regex is based on Apache Harmony, like old Android
   @GwtIncompatible // java.util.regex.Pattern
-  @AndroidIncompatible // Bug in older versions of Android we test against, since fixed.
   public void testPatternSplitLookBehind() {
     if (!CommonPattern.isPcreLike()) {
       return;
@@ -373,7 +372,6 @@ public void testPatternSplitLookBehind() {
 
   @J2ktIncompatible // Kotlin Native's regex is based on Apache Harmony, like old Android
   @GwtIncompatible // java.util.regex.Pattern
-  @AndroidIncompatible // Bug in older versions of Android we test against, since fixed.
   public void testPatternSplitWordBoundary() {
     String string = "foo<bar>bletch";
     Iterable<String> words = Splitter.on(Pattern.compile("\\b")).split(string);
@@ -387,7 +385,6 @@ public void testPatternSplitWordBoundary_singleCharInput() {
     assertThat(words).containsExactly("f").inOrder();
   }
 
-  @AndroidIncompatible // Apparently Gingerbread's regex API is buggy.
   @J2ktIncompatible // Kotlin Native's regex is based on Apache Harmony, like old Android
   @GwtIncompatible // java.util.regex.Pattern
   public void testPatternSplitWordBoundary_singleWordInput() {

android/guava-tests/test/com/google/common/base/SuppliersTest.java

@@ -471,7 +471,6 @@ public void testSuppliersNullChecks() throws Exception {
 
   @J2ktIncompatible
   @GwtIncompatible // reflection
-  @AndroidIncompatible // TODO(cpovirk): ClassNotFoundException: com.google.common.base.Function
   public void testSuppliersSerializable() throws Exception {
     new ClassSanityTester()
         .setDefault(Duration.class, Duration.ofSeconds(1))

android/guava-tests/test/com/google/common/base/ThrowablesTest.java

@@ -41,7 +41,6 @@
 import com.google.common.base.TestExceptions.SomeOtherCheckedException;
 import com.google.common.base.TestExceptions.SomeUncheckedException;
 import com.google.common.base.TestExceptions.YetAnotherCheckedException;
-import com.google.common.primitives.Ints;
 import com.google.common.testing.NullPointerTester;
 import java.util.List;
 import junit.framework.TestCase;
@@ -350,17 +349,12 @@ public void testGetCauseAs() {
     assertThat(expected).hasCauseThat().isEqualTo(thrown);
   }
 
-  @AndroidIncompatible // No getJavaLangAccess in Android (at least not in the version we use).
   @J2ktIncompatible
   @GwtIncompatible // lazyStackTraceIsLazy()
   public void testLazyStackTraceWorksInProd() {
-    // TODO(b/64442212): Remove this guard once lazyStackTrace() works in Java 9+.
-    Integer javaVersion = Ints.tryParse(JAVA_SPECIFICATION_VERSION.value());
-    if (javaVersion != null && javaVersion >= 9) {
-      return;
-    }
-    // Obviously this isn't guaranteed in every environment, but it works well enough for now:
-    assertTrue(lazyStackTraceIsLazy());
+    String javaVersion = JAVA_SPECIFICATION_VERSION.value();
+    assertThat(lazyStackTraceIsLazy()).isEqualTo(isJava8());
+    // TODO(b/64442212): Someday make lazyStackTrace() works in Java 9+?
   }
 
   @J2ktIncompatible
@@ -388,4 +382,9 @@ public void testLazyStackTrace() {
   public void testNullPointers() {
     new NullPointerTester().testAllPublicStaticMethods(Throwables.class);
   }
+
+  @GwtIncompatible
+  private static boolean isJava8() {
+    return JAVA_SPECIFICATION_VERSION.value().equals("1.8");
+  }
 }

android/guava-tests/test/com/google/common/base/Utf8Test.java

@@ -204,6 +204,7 @@ public void testIsWellFormed_2Bytes() {
 
   /** Tests that round tripping of all three byte permutations work. */
   @GwtIncompatible // java.nio.charset.Charset
+  // Android: takes ~70s
   public void testIsWellFormed_3Bytes() {
     testBytes(3, EXPECTED_THREE_BYTE_ROUNDTRIPPABLE_COUNT);
   }

android/guava-tests/test/com/google/common/collect/ImmutableRangeMapTest.java

@@ -172,7 +172,7 @@ public void testGetLargeRangeMap() {
     }
   }
 
-  @AndroidIncompatible // slow
+  // Android: takes ~25s
   public void testAsMapOfRanges() {
     for (Range<Integer> range1 : RANGES) {
       for (Range<Integer> range2 : RANGES) {
@@ -200,7 +200,7 @@ public void testAsMapOfRanges() {
     }
   }
 
-  @AndroidIncompatible // ~40s; doable but probably not worth it. We could test on fewer ranges
+  @AndroidIncompatible // ~30s; doable but probably not worth it. We could test on fewer ranges
 
   public void testSubRangeMap() {
     for (Range<Integer> range1 : RANGES) {

android/guava-tests/test/com/google/common/collect/ImmutableRangeSetTest.java

@@ -369,7 +369,6 @@ public void testRemoveAllUnsupported() {
         () -> rangeSet.removeAll(ImmutableRangeSet.of(Range.closed(6, 8))));
   }
 
-  @AndroidIncompatible // slow
   public void testExhaustive() {
     ImmutableSet<Range<Integer>> ranges =
         ImmutableSet.of(

android/guava-tests/test/com/google/common/collect/ImmutableTableTest.java

@@ -441,7 +441,6 @@ private static <R, C, V> void validateReserialization(Table<R, C, V> original) {
 
   @J2ktIncompatible
   @GwtIncompatible // Mind-bogglingly slow in GWT
-  @AndroidIncompatible // slow
   public void testOverflowCondition() {
     // See https://github.com/google/guava/issues/1322 for details.
     ImmutableTable.Builder<Integer, Integer, String> builder = ImmutableTable.builder();