Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proto] LOI Metadata is swapped #1921

Closed
Tracked by #1758
sufyanAbbasi opened this issue Jul 19, 2024 · 1 comment · Fixed by #1923
Closed
Tracked by #1758

[Proto] LOI Metadata is swapped #1921

sufyanAbbasi opened this issue Jul 19, 2024 · 1 comment · Fixed by #1923
Assignees

Comments

@sufyanAbbasi
Copy link
Contributor

sufyanAbbasi commented Jul 19, 2024

There is a bug here, the level here is swapped:

? Pb.Task.DataCollectionLevel.LOI_DATA

    level: task.addLoiTask
      ? Pb.Task.DataCollectionLevel.LOI_DATA
      : Pb.Task.DataCollectionLevel.LOI_METADATA,
    conditions: toTaskConditionMessage(task.condition),

According to the proto, the LOI_METADATA belongs to the geometry for the LOI task whereas LOI_DATA is for the non-LOI tasks.

  // Defines possible values of the `level` field.
  enum DataCollectionLevel {
    // Default value when level is not specified.
    DATA_COLLECTION_LEVEL_UNSPECIFIED = 0;

    // Data collected at this level is used to define a location of
    // interest (LOI). Specifically, geometry tasks of this type may be used
    // to allow data collectors to define the LOI's geometry. Future
    // implementations may use this to allow other LOI properties to be
    // added or modified.
    LOI_METADATA = 1;

    // Data collected at this level is associated with, but does not define,
    // a location of interest (LOI). Specifically, geometry tasks of this
    // type define one or more annotations of the associated LOI. rather
    // than the geometry of the LOI itself.
    LOI_DATA = 2;
  }

Simple fix is to swap them.

@gino-m
Copy link
Collaborator

gino-m commented Jul 19, 2024

@rfontanarosa For your attention

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants