Skip to content

[Proto] LOI Metadata is swapped #1921

Closed
@sufyanAbbasi

Description

@sufyanAbbasi

There is a bug here, the level here is swapped:

? Pb.Task.DataCollectionLevel.LOI_DATA

    level: task.addLoiTask
      ? Pb.Task.DataCollectionLevel.LOI_DATA
      : Pb.Task.DataCollectionLevel.LOI_METADATA,
    conditions: toTaskConditionMessage(task.condition),

According to the proto, the LOI_METADATA belongs to the geometry for the LOI task whereas LOI_DATA is for the non-LOI tasks.

  // Defines possible values of the `level` field.
  enum DataCollectionLevel {
    // Default value when level is not specified.
    DATA_COLLECTION_LEVEL_UNSPECIFIED = 0;

    // Data collected at this level is used to define a location of
    // interest (LOI). Specifically, geometry tasks of this type may be used
    // to allow data collectors to define the LOI's geometry. Future
    // implementations may use this to allow other LOI properties to be
    // added or modified.
    LOI_METADATA = 1;

    // Data collected at this level is associated with, but does not define,
    // a location of interest (LOI). Specifically, geometry tasks of this
    // type define one or more annotations of the associated LOI. rather
    // than the geometry of the LOI itself.
    LOI_DATA = 2;
  }

Simple fix is to swap them.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Status

Done

Relationships

None yet

Development

No branches or pull requests

Issue actions