GlslReduceTest.checkCustomJudgeIsExecutable: skip on Windows (#371)

Fix #370

Author: paulthomson

reducer/src/test/java/com/graphicsfuzz/reducer/tool/GlslReduceTest.java

@@ -21,6 +21,7 @@
 import com.graphicsfuzz.common.util.ParseHelper;
 import com.graphicsfuzz.common.util.ParseTimeoutException;
 import com.graphicsfuzz.common.util.ShaderJobFileOperations;
+import com.graphicsfuzz.util.ExecHelper;
 import java.io.File;
 import java.io.IOException;
 import org.junit.Rule;
@@ -29,6 +30,7 @@
 
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
 
 public class GlslReduceTest {
 
@@ -120,6 +122,10 @@ public void customJudgeRequiredInCustomReduction() throws Exception {
 
   @Test
   public void checkCustomJudgeIsExecutable() throws Exception {
+    if (ExecHelper.IS_WINDOWS) {
+      // All files are executable on Windows.
+      return;
+    }
     final File jsonFile = getShaderJobReady();
     final File emptyFile = temporaryFolder.newFile(); // Not executable
     try {
@@ -130,8 +136,7 @@ public void checkCustomJudgeIsExecutable() throws Exception {
           emptyFile.getAbsolutePath(),
           "--output",
           temporaryFolder.getRoot().getAbsolutePath()}, null);
-      assertTrue("An exception should have been thrown as the " +
-          "judge script is not executable.", false);
+      fail("An exception should have been thrown as the judge script is not executable.");
     } catch (RuntimeException exception) {
       assertTrue(exception.getMessage().contains("judge script must be executable"));
     }

util/src/main/java/com/graphicsfuzz/util/ExecHelper.java

@@ -39,7 +39,7 @@ public enum RedirectType {
 
   private static final Logger LOGGER = LoggerFactory.getLogger(ExecHelper.class);
 
-  private static final boolean isWindows =
+  public static final boolean IS_WINDOWS =
       System.getProperty("os.name").toLowerCase().startsWith("windows");
 
   private static final String pathVar;
@@ -78,7 +78,7 @@ public ExecResult exec(
     List<String> commandList = new ArrayList<>(Arrays.asList(command));
 
     if (shell) {
-      if (isWindows) {
+      if (IS_WINDOWS) {
         commandList.addAll(0, Arrays.asList("cmd.exe", "/c"));
       } else {
         commandList.addAll(0, Arrays.asList("env", "--"));