Plugin didn't change wrong name of var

[peewe]

Hello , I noticed that the plugin google-java-format does not change names which contains non ASCII chars.
According to, google-java-style it should change them or warning, but it doesn't do that. How do I fix it?
Thanks and have a nice day :)

[lowasser]

? g-j-f only makes whitespace changes at this time, and that is working as intended. The formatter couldn't possibly make reasonable decisions here when it encounters non ASCII identifiers; that really requires a human's touch.

[alexkleiman]

@lowasser Is it possible that @peewe is asking why g-j-f doesn’t replace the non-ASCII versions of characters [a-z0-9A-Z] with their ASCII equivalents.

I don't know whether this is a desired feature or not, but it does at least some like something which requires less of a human touch.

[kevinb9n]

This change could only be made for private symbols, and even then could theoretically break reflection. I think it's far outside the realm of things a code formatter should do.

…

On Tue, Apr 4, 2017 at 9:17 AM, alexkleiman ***@***.***> wrote: @lowasser <https://github.com/lowasser> Is it possible that @peewe <https://github.com/peewe> is asking why g-j-f doesn’t replace the non-ASCII versions of characters [a-z0-9A-Z] with their ASCII equivalents. I don't know whether this is a desired feature or not, but it does at least some like something which requires less of a human touch. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#142 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA5Cl9VWZeROkjTjLcjxDKYATYRXduvjks5rsm0QgaJpZM4MyqTB> .

-- Kevin Bourrillion | Java Librarian | Google, Inc. | [email protected]

[sormuras]

GJF could emit a warning.

[kevinb9n]

checkstyle <http://checkstyle.sourceforge.net/google_style.html> is good at reporting style guide violations. That's what it does (as the name of the tool suggests). What google-java-format does (as *its* name suggests) is *format* code. It doesn't care whether you use a Mongolian vowel separator in your variable names.

…

On Tue, Apr 4, 2017 at 9:27 AM, Christian Stein ***@***.***> wrote: GJF could emit a warning. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#142 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA5Cl-OmI7D1TxTYzi11X8HcHUOIZftlks5rsm9dgaJpZM4MyqTB> .

-- Kevin Bourrillion | Java Librarian | Google, Inc. | [email protected]

[sormuras]

Point taken.

[sormuras]

Is the same reasoning applicable to not consider a validation mode described in #105 (and implemented in #106)?

[kevinb9n]

No, I think validation is fine as long as people understand that it means both much more and much less than validating style correctness.