Skip to content

Fixed deprecated .value usage failing CI tests #5097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2025
Merged

Fixed deprecated .value usage failing CI tests #5097

merged 1 commit into from
Nov 18, 2025

Conversation

@vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Nov 18, 2025

No description provided.

@vfdev-5 vfdev-5 marked this pull request as ready for review November 18, 2025 10:23
@IvyZX
Copy link
Collaborator

IvyZX commented Nov 18, 2025

Got errors from some internal user:

  File "flax/nnx/variablelib.py", line 1715, in __eq__
    other = other[...]
            ~~~~~^^^^^
  File "flax/nnx/variablelib.py", line 1664, in __getitem__
    return self.get_value(index=key)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "flax/nnx/variablelib.py", line 1419, in get_value
    value = value[index]
            ~~~~~^^^^^^^
KeyError: Ellipsis

@vfdev-5 vfdev-5 requested a review from IvyZX November 18, 2025 21:35
IvyZX
IvyZX requested changes Nov 18, 2025
View reviewed changes
@vfdev-5 vfdev-5 requested a review from IvyZX November 18, 2025 22:26
@copybara-service copybara-service bot merged commit bee81ed into main Nov 18, 2025
21 checks passed
@copybara-service copybara-service bot deleted the fix-main-4 branch November 18, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IvyZX IvyZX Awaiting requested review from IvyZX

Assignees

No one assigned

Labels

pull ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vfdev-5 @IvyZX