Remove obsolete check for value_type in DCF constructor

PiperOrigin-RevId: 848291169

Author: schoppmp

dcf/distributed_comparison_function.cc

@@ -54,13 +54,6 @@ DistributedComparisonFunction::Create(const DcfParameters& parameters) {
     return absl::InvalidArgumentError("A DCF must have log_domain_size >= 1");
   }
 
-  // We don't support the legacy element_bitsize field in DCFs.
-  if (!parameters.parameters().has_value_type()) {
-    return absl::InvalidArgumentError(
-        "parameters.value_type must be set for "
-        "DistributedComparisonFunction::Create");
-  }
-
   // Create parameter vector for the incremental DPF.
   std::vector<DpfParameters> dpf_parameters(
       parameters.parameters().log_domain_size());

dcf/distributed_comparison_function_test.cc

@@ -66,6 +66,16 @@ TEST(DcfTest, CreateFailsWithZeroLogDomainSize) {
                                      "A DCF must have log_domain_size >= 1"));
 }
 
+TEST(DcfTest, CreateFailsWithoutValueType) {
+  DcfParameters parameters;
+  parameters.mutable_parameters()->set_log_domain_size(10);
+  // don't set value_type
+
+  EXPECT_THAT(DistributedComparisonFunction::Create(parameters),
+              dpf_internal::StatusIs(absl::StatusCode::kInvalidArgument,
+                                     HasSubstr("ValueType")));
+}
+
 template <typename T, int log_domain_size>
 class DcfTestParameters {
  public: