sysfs: trim spaces in device hidden check

clwluvw · clwluvw · commit 34f50e5524f8 · 2024-04-24T21:15:41.000+02:00
The hidden file might have an endline, so the check for equals to 1 would not be true.
Trimming the spaces would help to cover this case.

Signed-off-by: Seena Fallah &lt;seenafallah@gmail.com&gt;
diff --git a/utils/sysfs/sysfs.go b/utils/sysfs/sysfs.go
@@ -229,10 +229,8 @@ func (fs *realSysFs) IsBlockDeviceHidden(name string) (bool, error) {
 	if err != nil {
 		return false, fmt.Errorf("failed to read %s: %w", devHiddenPath, err)
 	}
-	if string(hidden) == "1" {
-		return true, nil
-	}
-	return false, nil
+
+	return strings.TrimSpace(string(hidden)) == "1", nil
 }
 
 func (fs *realSysFs) GetBlockDeviceScheduler(name string) (string, error) {

Original file line number	Diff line number	Diff line change
`@@ -229,10 +229,8 @@ func (fs *realSysFs) IsBlockDeviceHidden(name string) (bool, error) {`
`229`	`229`	`if err != nil {`
`230`	`230`	`return false, fmt.Errorf("failed to read %s: %w", devHiddenPath, err)`
`231`	`231`	`}`
`232`		`- if string(hidden) == "1" {`
`233`		`- return true, nil`
`234`		`- }`
`235`		`- return false, nil`
	`232`	`+`
	`233`	`+ return strings.TrimSpace(string(hidden)) == "1", nil`
`236`	`234`	`}`
`237`	`235`
`238`	`236`	`func (fs *realSysFs) GetBlockDeviceScheduler(name string) (string, error) {`