chore: quick lint configuration

Author: ldez

.golangci.yml

@@ -0,0 +1,87 @@
+version: "2"
+
+formatters:
+  enable:
+    - gci
+    - gofumpt
+  settings:
+    gofumpt:
+      extra-rules: true
+
+linters:
+  default: all
+  disable:
+    - cyclop # duplicate of gocyclo
+    - dupl
+    - errchkjson
+    - exhaustive
+    - exhaustruct
+    - lll
+    - mnd
+    - nilnil
+    - nlreturn
+    - nonamedreturns
+    - paralleltest
+    - prealloc
+    - rowserrcheck # not relevant (SQL)
+    - sqlclosecheck # not relevant (SQL)
+    - testpackage
+    - tparallel
+    - varnamelen
+    - wsl # Deprecated
+    - forcetypeassert # recheck in the future.
+
+  settings:
+    depguard:
+      rules:
+        main:
+          deny:
+            - pkg: github.com/instana/testify
+              desc: not allowed
+            - pkg: github.com/pkg/errors
+              desc: Should be replaced by standard lib errors package
+    funlen:
+      lines: -1
+      statements: 40
+    goconst:
+      min-len: 5
+      min-occurrences: 3
+    gocritic:
+      disabled-checks:
+        - sloppyReassign
+        - rangeValCopy
+        - octalLiteral
+        - paramTypeCombine # already handle by gofumpt.extra-rules
+      enabled-tags:
+        - diagnostic
+        - style
+        - performance
+      settings:
+        hugeParam:
+          sizeThreshold: 100
+    gocyclo:
+      min-complexity: 20
+    godox:
+      keywords:
+        - FIXME
+    govet:
+      disable:
+        - fieldalignment
+      enable-all: true
+    misspell:
+      locale: US
+    mnd:
+      ignored-numbers:
+        - "124"
+    wsl:
+      force-case-trailing-whitespace: 1
+      allow-trailing-comment: true
+  exclusions:
+    presets:
+      - comments
+      - std-error-handling
+      - common-false-positives
+
+issues:
+  max-issues-per-linter: 0
+  max-same-issues: 0

ascii_test.go

@@ -42,24 +42,24 @@ func BenchmarkIsASCII(b *testing.B) {
 	for _, size := range sizes {
 		b.Run(fmt.Sprintf("Len=%d", size), func(b *testing.B) {
 			s := generateString(size)
+
 			b.ReportAllocs()
 			b.ResetTimer()
 
-			for i := 0; i < b.N; i++ {
+			for range b.N {
 				if _, ok := isASCII(s); !ok {
 					b.Fatal("unexpected result")
 				}
 			}
 		})
-
 	}
-
 }
 
 func generateString(l int) string {
 	s := make([]byte, l)
 	for i := range s {
 		s[i] = byte(i)
 	}
+
 	return string(s)
 }

asciicheck.go

@@ -20,7 +20,7 @@ func NewAnalyzer() *analysis.Analyzer {
 }
 
 func run(pass *analysis.Pass) (any, error) {
-	inspect := pass.ResultOf[inspect.Analyzer].(*inspector.Inspector)
+	insp := pass.ResultOf[inspect.Analyzer].(*inspector.Inspector)
 
 	nodeFilter := []ast.Node{
 		(*ast.File)(nil),
@@ -35,7 +35,7 @@ func run(pass *analysis.Pass) (any, error) {
 		(*ast.AssignStmt)(nil),
 	}
 
-	inspect.Preorder(nodeFilter, func(n ast.Node) {
+	insp.Preorder(nodeFilter, func(n ast.Node) {
 		switch n := n.(type) {
 		case *ast.File:
 			checkIdent(pass, n.Name)
@@ -71,6 +71,7 @@ func run(pass *analysis.Pass) (any, error) {
 			}
 		}
 	})
+
 	return nil, nil
 }
 
@@ -84,7 +85,7 @@ func checkIdent(pass *analysis.Pass, v *ast.Ident) {
 		pass.Report(
 			analysis.Diagnostic{
 				Pos:     v.Pos(),
-				Message: fmt.Sprintf("identifier \"%s\" contain non-ASCII character: %#U", v.Name, ch),
+				Message: fmt.Sprintf("identifier %q contain non-ASCII character: %#U", v.Name, ch),
 			},
 		)
 	}
@@ -94,6 +95,7 @@ func checkFieldList(pass *analysis.Pass, f *ast.FieldList) {
 	if f == nil {
 		return
 	}
+
 	for _, f := range f.List {
 		for _, name := range f.Names {
 			checkIdent(pass, name)