Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide official harbor dashboard via grafana website #19948

Closed
volker-raschek opened this issue Feb 4, 2024 · 3 comments
Closed

provide official harbor dashboard via grafana website #19948

volker-raschek opened this issue Feb 4, 2024 · 3 comments
Assignees

Comments

@volker-raschek
Copy link

volker-raschek commented Feb 4, 2024

Is your feature request related to a problem? Please describe.

Yes, I've deployed grafana via the prometheus operator stack. The deployment of grafana has a feature to download dashboards from custom resources - for example via url, grafana net id or as raw json. For example:

dashboards:
    default:
      # some-dashboard:
      #   json: |
      #     $RAW_JSON
      # custom-dashboard:
      #   file: dashboards/custom-dashboard.json
      # local-dashboard:
      #   url: https://example.com/repository/test.json
      #   token: ''
      # local-dashboard-base64:
      #   url: https://example.com/repository/test-b64.json
      #   token: ''
      #   b64content: true
      # local-dashboard-gitlab:
      #   url: https://example.com/repository/test-gitlab.json
      #   gitlabToken: ''
      # local-dashboard-bitbucket:
      #   url: https://example.com/repository/test-bitbucket.json
      #   bearerToken: ''
      # local-dashboard-azure:
      #   url: https://example.com/repository/test-azure.json
      #   basic: ''
      #   acceptHeader: '*/*'
      argocd:
        gnetId: 14584
        revision: 1
        datasource: Prometheus

The current problem is, that the dashboard located in contrib leads to an EOF error:

logger=provisioning.dashboard type=file name=default t=2024-02-04T17:05:31.128692475Z level=error msg="failed to load dashboard from " file=/var/lib/grafana/dashboards/default/harbor.json error="unexpected EOF"

Describe the solution you'd like

For me it is not clear why to "official" grafana dashboard is hidden as part of this project inside the contrib directory. Furthermore, DevOps teams search initially after official grafana dashboards via the grafana dashboard website. There are some unofficial dashboards, where the DevOps team take the risk, that the dashboard could be unmaintained, when a newer version of harbor breaks the dashboard.

Reagarding the import mechanism, which leads to the EOF error - if the dashboard is located via the grafana dashboard website, the dashboard receives a dashboard id like gnetId and a revision. Via this information, a reproducible deployment can be guaranteed, because currently by using the rawURL directly can be leads to incompatibility between dashbord and harbor version.

So, please provide the dashboard via the grafana dashboard website and make it possible for devops engineers to setup a reproducible deployment of a grafana dashboard. Maybe it is possible to upload the dashboard from GitHub to the grafana website via the CI.

Volker

@volker-raschek volker-raschek changed the title provide harbor dashboard via grafana provide official harbor dashboard via grafana website Feb 4, 2024
@zyyw
Copy link
Contributor

zyyw commented Feb 5, 2024

Hi @volker-raschek , regarding using prometheus and grafana against Harbor instance, maybe you want to have a try on this PR:

Copy link

github-actions bot commented Apr 8, 2024

This issue is being marked stale due to a period of inactivity. If this issue is still relevant, please comment or remove the stale label. Otherwise, this issue will close in 30 days.

@github-actions github-actions bot added the Stale label Apr 8, 2024
Copy link

github-actions bot commented May 9, 2024

This issue was closed because it has been stalled for 30 days with no activity. If this issue is still relevant, please re-open a new issue.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants