Possible problem where a `paid_out` event arrives after a `failed` event

[nicdwilson]

Describe the Bug

This is a potential bug. I don't have access to enough data to be 100% sure on this. However, this thread should serve as a point to collect more data.

In 9285450-zen we see that a failed order did not run payment_complete when the successful transaction is received after a failed notice.

Since the site had no logs activated, it's pretty tough to figure out what is going on here, but logs from GoCardless appear to confirm that a paid_out was received after a failed first attempt to charge this subscription.

In the order note we have The payment failed but the reason for the failure was not provided, usually for regulatory reasons. Status der Bestellung von In Bearbeitung auf Fehlgeschlagen geändert.

We can see no _gocardless_temporary_activated data in the database. This would be correct, because if an end status (failed) is received, it is removed.

I think the problem here is that submitted was received for this payment before failed and therefore the paid_out arrived with:

• The order in a failed state
• _gocardless_temporary_activated had been removed.

The paid_out event in GoCardless shows a 200 response from the site. Assuming that the order was marked failed, the problem is the logic here.

However: we need more data and a potential confirmation on this.

[iamdharmesh]

I have checked this, and it seems the merchant is experiencing an issue with marking the order as processing when the payment fails initially. However, the code reference provided here relates to the subscription payment status check, which is essentially a temporary cron job that keeps checking the payment status of the order until it reaches a final status (in this case, "failed"). No further handling is required by this cron job, as its sole purpose is to update the order to the correct status, which we temporarily set to "processing" at the time of subscription purchase.

Now, if the payment is retried manually or automatically by GoCardless after it fails and eventually succeeds (confirmed or paid out), the order and subscription statuses are updated correctly by our webhook handler, as expected. So, we might consider keeping this in the backlog for a while to monitor for any similar reports, but otherwise, we should just close this.

Thanks!