Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API response consistency #2939

Open
stakersunion opened this issue Aug 18, 2024 · 0 comments
Open

API response consistency #2939

stakersunion opened this issue Aug 18, 2024 · 0 comments

Comments

@stakersunion
Copy link

Describe the bug
Currently, the response from endpoints returning similar data types are inconsistent.

GET /api/v1/validator/eth1/{eth1address}

{
  "data": [
    {
      "public_key": "string",
      "valid_signature": true,
      "validator_index": 0
    }
  ],
  "status": "string"
}

GET /api/v1/validator/withdrawalCredentials/{withdrawalCredentialsOrEth1address}

{
  "data": [
    {
      "publickey": "string",
      "validatorindex": 0
    }
  ],
  "status": "string"
}

Expected behavior
Consider using common key names (ex. include underscore).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@stakersunion and others