Skip to content

Commit e598b6e

Browse files
authored
Skip decoding of excluded table rows (#831)
* refactor: move decompression into DecodeData method * feat: skip decoding of row events for tables we are not interested in
1 parent d5dd3d6 commit e598b6e

File tree

2 files changed

+21
-7
lines changed

2 files changed

+21
-7
lines changed

canal/canal.go

+13
Original file line numberDiff line numberDiff line change
@@ -451,6 +451,19 @@ func (c *Canal) prepareSyncer() error {
451451
Logger: c.cfg.Logger,
452452
Dialer: c.cfg.Dialer,
453453
Localhost: c.cfg.Localhost,
454+
RowsEventDecodeFunc: func(event *replication.RowsEvent, data []byte) error {
455+
pos, err := event.DecodeHeader(data)
456+
if err != nil {
457+
return err
458+
}
459+
460+
key := fmt.Sprintf("%s.%s", string(event.Table.Schema), string(event.Table.Table))
461+
if !c.checkTableMatch(key) {
462+
return nil
463+
}
464+
465+
return event.DecodeData(pos, data)
466+
},
454467
}
455468

456469
if strings.Contains(c.cfg.Addr, "/") {

replication/row_event.go

+8-7
Original file line numberDiff line numberDiff line change
@@ -1018,6 +1018,14 @@ func (e *RowsEvent) decodeExtraData(data []byte) (err2 error) {
10181018
}
10191019

10201020
func (e *RowsEvent) DecodeData(pos int, data []byte) (err2 error) {
1021+
if e.compressed {
1022+
data, err2 = DecompressMariadbData(data[pos:])
1023+
if err2 != nil {
1024+
//nolint:nakedret
1025+
return
1026+
}
1027+
}
1028+
10211029
// Rows_log_event::print_verbose()
10221030

10231031
var (
@@ -1073,13 +1081,6 @@ func (e *RowsEvent) Decode(data []byte) error {
10731081
if err != nil {
10741082
return err
10751083
}
1076-
if e.compressed {
1077-
uncompressedData, err := DecompressMariadbData(data[pos:])
1078-
if err != nil {
1079-
return err
1080-
}
1081-
return e.DecodeData(0, uncompressedData)
1082-
}
10831084
return e.DecodeData(pos, data)
10841085
}
10851086

0 commit comments

Comments
 (0)