replace loop with another OnesCount8

serprex · serprex · commit 9bda9931a78d · 2025-02-21T04:57:50.000Z
diff --git a/replication/row_event.go b/replication/row_event.go
@@ -1154,10 +1154,8 @@ func (e *RowsEvent) decodeImage(data []byte, bitmap []byte, rowImageType EnumRow
 	for ; col+8 <= int(e.ColumnCount); col += 8 {
 		count += bits.OnesCount8(bitmap[col>>3])
 	}
-	for ; col < int(e.ColumnCount); col++ {
-		if isBitSet(bitmap, col) {
-			count++
-		}
+	if col < int(e.ColumnCount) {
+		count += bits.OnesCount8(bitmap[col>>3] & byte((1<<int(e.ColumnCount)-col)-1))
 	}
 	skips := make([]int, 0, int(e.ColumnCount)-count)
 	count = bitmapByteSize(count)

Original file line number	Diff line number	Diff line change
`@@ -1154,10 +1154,8 @@ func (e *RowsEvent) decodeImage(data []byte, bitmap []byte, rowImageType EnumRow`
`1154`	`1154`	`for ; col+8 <= int(e.ColumnCount); col += 8 {`
`1155`	`1155`	`count += bits.OnesCount8(bitmap[col>>3])`
`1156`	`1156`	`}`
`1157`		`- for ; col < int(e.ColumnCount); col++ {`
`1158`		`- if isBitSet(bitmap, col) {`
`1159`		`- count++`
`1160`		`- }`
	`1157`	`+ if col < int(e.ColumnCount) {`
	`1158`	`+ count += bits.OnesCount8(bitmap[col>>3] & byte((1<<int(e.ColumnCount)-col)-1))`
`1161`	`1159`	`}`
`1162`	`1160`	`skips := make([]int, 0, int(e.ColumnCount)-count)`
`1163`	`1161`	`count = bitmapByteSize(count)`