Skip to content

Commit 4113355

Browse files
serprexlance6716
andauthored
lance feedback
Co-authored-by: lance6716 <[email protected]>
1 parent dccc896 commit 4113355

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

README.md

+2
Original file line numberDiff line numberDiff line change
@@ -492,6 +492,8 @@ We pass all tests in https://github.com/bradfitz/go-sql-test using go-mysql driv
492492

493493
Logging uses [log/slog](https://pkg.go.dev/log/slog) and by default is sent to standard out.
494494

495+
For the old logging package `github.com/siddontang/go-log/log`, a converting package
496+
`https://github.com/serprex/slog-siddontang` is available.
495497
## How to migrate to this repo
496498
To change the used package in your repo it's enough to add this `replace` directive to your `go.mod`:
497499
```

replication/binlogsyncer.go

+1
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,7 @@ func NewBinlogSyncer(cfg BinlogSyncerConfig) *BinlogSyncer {
171171
cfg.Logger = slog.Default()
172172
}
173173
if cfg.ServerID == 0 {
174+
cfg.Logger.Error("can't use 0 as the server ID, will panic")
174175
panic("can't use 0 as the server ID")
175176
}
176177
if cfg.Dialer == nil {

0 commit comments

Comments
 (0)