update

Author: dveeden

client/conn.go

@@ -306,7 +306,7 @@ func (c *Conn) Execute(command string, args ...interface{}) (*Result, error) {
 // flag set to signal the server multiple queries are executed. Handling the responses
 // is up to the implementation of perResultCallback.
 func (c *Conn) ExecuteMultiple(query string, perResultCallback ExecPerResultCallback) (*Result, error) {
-	if err := c.writeCommandStr(COM_QUERY, query); err != nil {
+	if err := c.exec_send(query); err != nil {
 		return nil, errors.Trace(err)
 	}
 
@@ -359,7 +359,7 @@ func (c *Conn) ExecuteMultiple(query string, perResultCallback ExecPerResultCall
 //
 // ExecuteSelectStreaming should be used only for SELECT queries with a large response resultset for memory preserving.
 func (c *Conn) ExecuteSelectStreaming(command string, result *Result, perRowCallback SelectPerRowCallback, perResultCallback SelectPerResultCallback) error {
-	if err := c.writeCommandStr(COM_QUERY, command); err != nil {
+	if err := c.exec_send(command); err != nil {
 		return errors.Trace(err)
 	}
 
@@ -485,9 +485,18 @@ func (c *Conn) ReadOKPacket() (*Result, error) {
 	return c.readOK()
 }
 
+// Send COM_QUERY and read the result
+func (c *Conn) exec(query string) (*Result, error) {
+	err := c.exec_send(query)
+	if err != nil {
+		return nil, err
+	}
+	return c.readResult(false)
+}
+
 // Sends COM_QUERY
 // https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_com_query.html
-func (c *Conn) exec(query string) (*Result, error) {
+func (c *Conn) exec_send(query string) error {
 	var buf bytes.Buffer
 
 	if c.includeLine {
@@ -524,15 +533,15 @@ func (c *Conn) exec(query string) (*Result, error) {
 
 	_, err := buf.Write(utils.StringToByteSlice(query))
 	if err != nil {
-		return nil, err
+		return err
 	}
 
 	if err := c.writeCommandBuf(COM_QUERY, buf.Bytes()); err != nil {
-		return nil, errors.Trace(err)
+		return errors.Trace(err)
 	}
 	c.queryAttributes = nil
 
-	return c.readResult(false)
+	return nil
 }
 
 // CapabilityString is returning a string with the names of capability flags

client/stmt.go

@@ -119,23 +119,23 @@ func (s *Stmt) write(args ...interface{}) error {
 			paramValues[i] = Uint64ToBytes(uint64(v))
 		case uint8:
 			paramTypes[i] = []byte{MYSQL_TYPE_TINY}
-			paramFlags[i] = []byte{BINARY_FLAG}
+			paramFlags[i] = []byte{PARAM_UNSIGNED}
 			paramValues[i] = []byte{v}
 		case uint16:
 			paramTypes[i] = []byte{MYSQL_TYPE_SHORT}
-			paramFlags[i] = []byte{BINARY_FLAG}
+			paramFlags[i] = []byte{PARAM_UNSIGNED}
 			paramValues[i] = Uint16ToBytes(v)
 		case uint32:
 			paramTypes[i] = []byte{MYSQL_TYPE_LONG}
-			paramFlags[i] = []byte{BINARY_FLAG}
+			paramFlags[i] = []byte{PARAM_UNSIGNED}
 			paramValues[i] = Uint32ToBytes(v)
 		case uint:
 			paramTypes[i] = []byte{MYSQL_TYPE_LONGLONG}
-			paramFlags[i] = []byte{BINARY_FLAG}
+			paramFlags[i] = []byte{PARAM_UNSIGNED}
 			paramValues[i] = Uint64ToBytes(uint64(v))
 		case uint64:
 			paramTypes[i] = []byte{MYSQL_TYPE_LONGLONG}
-			paramFlags[i] = []byte{BINARY_FLAG}
+			paramFlags[i] = []byte{PARAM_UNSIGNED}
 			paramValues[i] = Uint64ToBytes(v)
 		case bool:
 			paramTypes[i] = []byte{MYSQL_TYPE_TINY}

mysql/const.go

@@ -178,6 +178,10 @@ const (
 	UNIQUE_FLAG         = 65536
 )
 
+const (
+	PARAM_UNSIGNED = 128
+)
+
 const (
 	DEFAULT_ADDR                  = "127.0.0.1:3306"
 	DEFAULT_IPV6_ADDR             = "[::1]:3306"